-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds notice to internals page #6187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we should also add a warning at the top of the log file itself, but this doesn't need to block this PR and can be added later.
I filed brave/brave-browser#10888 for this. |
Verification PASSED on
Verification details can be found under https://github.com/brave/internal/issues/713#issuecomment-663351330. |
Resolves brave/brave-browser#10873
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.