Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds notice to internals page #6187

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Adds notice to internals page #6187

merged 1 commit into from
Jul 23, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 23, 2020

Resolves brave/brave-browser#10873

Submitter Checklist:

Test Plan:

  • enable rewards
  • go to internals page
  • make sure that you see a notice

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 23, 2020
@NejcZdovc NejcZdovc requested review from fmarier and diracdeltas July 23, 2020 06:17
@NejcZdovc NejcZdovc self-assigned this Jul 23, 2020
@NejcZdovc NejcZdovc added the CI/skip-ios Do not run CI builds for iOS label Jul 23, 2020
@NejcZdovc NejcZdovc added CI/skip Do not run CI builds (except noplatform) and removed CI/skip-ios Do not run CI builds for iOS labels Jul 23, 2020
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should also add a warning at the top of the log file itself, but this doesn't need to block this PR and can be added later.

@fmarier
Copy link
Member

fmarier commented Jul 23, 2020

Ideally we should also add a warning at the top of the log file itself, but this doesn't need to block this PR and can be added later.

I filed brave/brave-browser#10888 for this.

@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.13.42 Chromium: 84.0.4147.89 (Official Build) nightly (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.15.6 (Build 19G73)

Verification details can be found under https://github.com/brave/internal/issues/713#issuecomment-663351330.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform) feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Add notice
4 participants