Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Brave Rewards service is associated to Tor Profiles - 1.14.x #6606

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Fixes Brave Rewards service is associated to Tor Profiles - 1.14.x #6606

merged 1 commit into from
Sep 10, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Sep 9, 2020 •
edited by kjozwiak
Loading

Uplift of #6418
Resolves brave/brave-browser#11223
Resolves brave/brave-browser#11042

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.14.x - Release milestone Sep 9, 2020
@tmancey tmancey requested a review from a team September 9, 2020 17:28
@tmancey tmancey requested a review from NejcZdovc as a code owner September 9, 2020 17:28
@tmancey tmancey self-assigned this Sep 9, 2020
@tmancey tmancey changed the title Fixes Brave Rewards service is associated to Tor Profiles Fixes Brave Rewards service is associated to Tor Profiles - 1.14.x Sep 9, 2020
kjozwiak
kjozwiak approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.14.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6418 (comment).

@kjozwiak kjozwiak merged commit 3937b44 into 1.14.x Sep 10, 2020
@kjozwiak kjozwiak deleted the issues/11223-1.14.x branch September 10, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@NejcZdovc NejcZdovc Awaiting requested review from NejcZdovc

Assignees

@tmancey tmancey

Labels
feature/rewards
Projects
None yet
Milestone
1.14.x - Release #1
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak