Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change to webpack that eliminated Node stream module shim #6891

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Oct 19, 2020

Resolves brave/brave-browser#12196

Submitter Checklist:

Test Plan:

Test plan in issue description.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@zenparsing zenparsing requested review from yrliou and ryanml October 19, 2020 17:58
@zenparsing zenparsing self-assigned this Oct 19, 2020
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@zenparsing zenparsing added this to the 1.17.x - Nightly milestone Oct 19, 2020
@zenparsing zenparsing merged commit 25cbe81 into master Oct 19, 2020
@zenparsing zenparsing deleted the revert-node-stream-shim branch October 19, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebTorrent not loading due to "Unchecked runtime.lastError: Could not establish connection" error
3 participants