Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes navigation bar on the Wallet page. #6998

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#12414

Related to e218200

Disabled trusted types CSP.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.18.x - Nightly milestone Oct 30, 2020
@mkarolin mkarolin self-assigned this Oct 30, 2020
Copy link
Contributor

@mariospr mariospr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarolin mkarolin removed this from the 1.18.x - Nightly milestone Oct 30, 2020
@mkarolin
Copy link
Collaborator Author

Unrelated known browser test failures on Windows and Mac.

@mkarolin mkarolin merged commit 338e6ee into master Oct 30, 2020
@mkarolin mkarolin deleted the maxk-fix-wallet-page-toolbar branch October 30, 2020 17:48
@mkarolin mkarolin added this to the 1.18.x - Nightly milestone Oct 30, 2020
@diracdeltas
Copy link
Member

In the future, please ping sec-team on slack if disabling trusted types on a page. thanks!

@mkarolin
Copy link
Collaborator Author

Thanks @diracdeltas, will do.

mkarolin added a commit that referenced this pull request Nov 7, 2020
Fixes navigation bar on the Wallet page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing the navigation bar in brave://wallet - C87 regression
4 participants