Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show blankpage only for normal window #7021

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 2, 2020

Resolves brave/brave-browser#12456

Submitter Checklist:

Test Plan:

npm run test brave_unit_tests -- --filter=*BraveNewTab*

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong self-assigned this Nov 2, 2020
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and clean

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simonhong
Copy link
Member Author

Merged because only unrelated rewards browser test was failed.

@simonhong simonhong merged commit cea70b4 into master Nov 4, 2020
@simonhong simonhong deleted the new_tab_shows_options branch November 4, 2020 08:25
@kjozwiak kjozwiak added this to the 1.18.x - Nightly milestone Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tab pages shows blank settings propagated to all windows types including PT and TOR
4 participants