-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds captcha error flow #721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
captcha-error
branch
4 times, most recently
from
October 24, 2018 08:07
ac3a1f4
to
04fee11
Compare
NejcZdovc
force-pushed
the
captcha-error
branch
2 times, most recently
from
October 24, 2018 14:40
00b8f7f
to
d052b35
Compare
NejcZdovc
force-pushed
the
captcha-error
branch
from
October 24, 2018 15:08
d052b35
to
65c6ff2
Compare
ryanml
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Updated label to 0.56.x since this won't appear in 0.55.x hotfix2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#1723
Resolves brave/brave-browser#1556
Resolves brave/brave-browser#1502
Resolves brave/brave-browser#1794
Ledger implementation: brave-intl/bat-native-ledger#156
UI implementation: brave/brave-ui#233
UI implementation: brave/brave-ui#231
UI implementation: brave/brave-ui#229
UI implementation: brave/brave-ui#227
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: