Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Global Privacy Control on all release channels (uplift to 1.18.x) #7240

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Enable Global Privacy Control on all release channels (uplift to 1.18.x) #7240

merged 1 commit into from
Nov 26, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 24, 2020 •
edited by kjozwiak
Loading

Uplift of #7238
Resolves brave/brave-browser#12875

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested review from iefremov and a team as code owners November 24, 2020 18:15
@brave-builds brave-builds requested a review from a team November 24, 2020 18:15
@brave-builds brave-builds self-assigned this Nov 24, 2020
@brave-builds brave-builds added this to the 1.18.x - Beta milestone Nov 24, 2020
@kjozwiak
Copy link
Member

Restarting macOS via https://ci.brave.com/job/pr-brave-browser-pr7238_gpc-all-platforms_1.18.x-macos/2/ due to build failing as per https://ci.brave.com/job/pr-brave-browser-pr7238_gpc-all-platforms_1.18.x-macos/1/execution/node/203/log/.

@kjozwiak
Copy link
Member

kjozwiak commented Nov 25, 2020 •
edited
Loading

Restarting macOS via https://ci.brave.com/job/pr-brave-browser-pr7238_gpc-all-platforms_1.18.x-macos/3/ as the node it's using was taken offline.

kjozwiak
kjozwiak approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 3201a06 into 1.18.x Nov 26, 2020
@kjozwiak kjozwiak deleted the pr7238_gpc-all-platforms_1.18.x branch November 26, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iefremov iefremov iefremov approved these changes

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @iefremov @brave-browser-releases