Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix path for resources #728

Merged
merged 1 commit into from
Oct 24, 2018
Merged

fix path for resources #728

merged 1 commit into from
Oct 24, 2018

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Oct 24, 2018 •
edited
Loading

This is a follow up for #719 to fix a windows build issue

@bridiver bridiver self-assigned this Oct 24, 2018
emerick
emerick approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

petemill
petemill approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested to know if this fixes all issues, but 👍 so that we can fix master ASAP

@bridiver bridiver merged commit 31dafd4 into master Oct 24, 2018
bridiver added a commit that referenced this pull request Oct 24, 2018
@bridiver
Merge pull request #728 from /issues/1808-followup
f569288 
fix path for resources
@bridiver
Copy link
Collaborator Author

bridiver commented Oct 24, 2018 •
edited by NejcZdovc
Loading

master 31dafd4
0.57.x 1a0de70
0.56.x f569288

bridiver added a commit that referenced this pull request Oct 25, 2018
@bridiver
Merge pull request #728 from /issues/1808-followup
1a0de70 
fix path for resources
@NejcZdovc NejcZdovc deleted the issues/1808-followup branch October 25, 2018 05:11
@bbondy bbondy added this to the 0.56.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@petemill petemill petemill approved these changes

Assignees

@bridiver bridiver

Labels
feature/rewards
Projects
None yet
Milestone
0.56.x - Release
Development

Successfully merging this pull request may close these issues.
5 participants
@bridiver @petemill @emerick @bbondy @NejcZdovc