Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for the IPFS diagnostics page brave://ipfs #7948

Merged
merged 9 commits into from
Feb 16, 2021
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 12, 2021

Resolves brave/brave-browser#13173

  • Add Restart button (speeds up applying config changes)
  • If not installed, note "IPFS not installed" and button to install and start; other items should be grayed out to indicate missing functionality
  • Additionally, display the Learn more about IPFS and privacy link described above (placement/appearance TBD once we know whether this diagnostic page can be included with the rest of Brave settings UI)
  • Added buttons to open Web UI
  • If the user has this diagnostic page open in one tab with their node stopped, and then starts their node from a different tab, this tab doesn't update unless it's reloaded.

image

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open brave://ipfs and play with buttons, all buttons should work as expected
  • Open 2 different windows with brave://ipfs page and try to stop/start node in one, the second one should update own status automatically

@spylogsster spylogsster self-assigned this Feb 12, 2021
@spylogsster spylogsster force-pushed the feature-13173 branch 6 times, most recently from d479c89 to 50afb13 Compare February 15, 2021 11:19
@bbondy bbondy merged commit 94e0c5e into master Feb 16, 2021
@bbondy bbondy deleted the feature-13173 branch February 16, 2021 16:33
@spylogsster spylogsster added this to the 1.22.x - Nightly milestone Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements for the IPFS diagnostics page brave://ipfs
2 participants