Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add installation progress to brave://ipfs page #8219

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Add installation progress to brave://ipfs page #8219

merged 1 commit into from
Mar 12, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 11, 2021 •
edited
Loading

Resolves brave/brave-browser#13170

Added node installation progress to ipfs diagnostic page

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Remove User Data
  • Simulate slow network connection in sniffer
  • open brave://ipfs and click install node
  • you will see the installation progress
  • if an error occurred you should be able to restart installation process

@spylogsster spylogsster requested a review from bbondy March 11, 2021 13:53
@spylogsster spylogsster requested a review from a team as a code owner March 11, 2021 13:53
@spylogsster spylogsster self-assigned this Mar 11, 2021
spylogsster
spylogsster commented Mar 11, 2021
View reviewed changes
patches/components-component_updater-component_updater_service.h.patch

friend class speech::SodaInstallerImpl;
friend class ::ComponentsHandler;
+ BRAVE_COMPONENT_UPDATER_SERVICE_H_
Copy link
Contributor Author

@spylogsster spylogsster Mar 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkarolin could you please check my changes to patches, I renamed old macros to meet the class name because I need to create another one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spylogsster this one is fine, the other one I would probably go with BRAVE_COMPONENT_UPDATER_SERVICE_H_ON_DEMAND_UPDATER, or just BRAVE_ON_DEMAND_UPDATER, otherwise it looks like it's in a wrong file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@spylogsster spylogsster force-pushed the ipfs-installation-progress branch 4 times, most recently from 3b35e8f to f5e27e4 Compare March 11, 2021 17:31
mkarolin
mkarolin approved these changes Mar 11, 2021
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src and patches changes LGTM

@spylogsster spylogsster merged commit b265c2a into master Mar 12, 2021
@spylogsster spylogsster deleted the ipfs-installation-progress branch March 12, 2021 15:33
@spylogsster spylogsster added this to the 1.23.x - Nightly milestone Mar 12, 2021
This was referenced Mar 16, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin mkarolin approved these changes

@bbondy bbondy bbondy approved these changes

Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
1.23.x - Release
Development

Successfully merging this pull request may close these issues.

Add visual feedback when installing IPFS
3 participants
@spylogsster @bbondy @mkarolin