Decouple AdsServiceImpl full screen mode business logic #8265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehickinson
approved these changes
Mar 16, 2021
That is correct, so mobile will work as before |
|
|
||
| // Assert | ||
| FullScreenModeFrequencyCap frequency_cap; | ||
| const bool is_allowed = frequency_cap.ShouldAllow(); |
There was a problem hiding this comment.
nit: in other frequency cap tests we have ShouldAllow() under // Act (and MockFullScreenMode(..) would be under // Arrange respectively
There was a problem hiding this comment.
same for all cases in this test
| @@ -58,6 +59,11 @@ bool FrequencyCapping::IsAdAllowed() { | |||
| return false; | |||
| } | |||
|
|
|||
| FullScreenModeFrequencyCap full_screen_node_frequency_cap; | |||
There was a problem hiding this comment.
nit: should be full_screen_mode_frequency_cap? ("m" instead of "n")
tmancey
force-pushed
the
issues/14762
branch
5 times, most recently
from
1e29655
to
8c3d3f7
Compare
|
CI failed due to known browser tests and audit deps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#14762
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Confirm ads are not shown when the browser is in full-screen mode (this mode is not the same as maximized windows)