Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables profile picker on startup feature (1.24.x). #8501

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#15212
Uplift from #8495

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

…artup

Disables profile picker on startup feature.
@mkarolin mkarolin requested a review from a team April 12, 2021 01:48
@mkarolin mkarolin self-assigned this Apr 12, 2021
@kjozwiak kjozwiak added this to the 1.24.x - Beta milestone Apr 13, 2021
@kjozwiak
Copy link
Member

Adding missing 1.24.x milestone label.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.24.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8495 (comment).

@kjozwiak kjozwiak merged commit 20fe77b into 1.24.x Apr 13, 2021
@kjozwiak kjozwiak deleted the maxk-disable-profile-picker-on-startup-1.24.x branch April 13, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants