Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fixes for Tab Groups option (uplift to 1.24.x) #8616

Merged
merged 1 commit into from
Apr 23, 2021
Merged

[Android] Fixes for Tab Groups option (uplift to 1.24.x) #8616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/java/org/chromium/chrome/browser/BraveFeatureList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public abstract class BraveFeatureList {
public static final String ENABLE_TAB_GROUPS = "enable-tab-groups";
public static final String ENABLE_TAB_GROUPS_DISABLED_VALUE = "2";
public static final String ENABLE_TAB_GRID = "enable-tab-grid-layout";
public static final String ENABLE_TAB_GRID_DISABLED_VALUE = "7";
public static final String ENABLE_TAB_GRID_DISABLED_VALUE = "8";

public static void enableFeature(String featureName, boolean enabled, String disabledValue) {
BraveFeatureListJni.get().enableFeature(featureName, enabled, disabledValue);
Expand Down
1 change: 1 addition & 0 deletions android/java/org/chromium/chrome/browser/settings/AppearancePreferences.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public void onCreate(Bundle savedInstanceState) {
ContextUtils.getApplicationContext());
if (isTablet) {
removePreferenceIfPresent(BravePreferenceKeys.BRAVE_BOTTOM_TOOLBAR_ENABLED_KEY);
removePreferenceIfPresent(PREF_BRAVE_ENABLE_TAB_GROUPS);
}

if (!NightModeUtils.isNightModeSupported()) {
Expand Down