Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds retries into contribution flow for rewards #890

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 12, 2018

Resolves brave/brave-browser#1483
Resolves brave/brave-browser#1481

Native implementation: brave-intl/bat-native-ledger#175

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

For easier debugging you can uncomment this sections https://github.com/brave-intl/bat-native-ledger/pull/175/files#diff-e91798fe1b25491970c7c977e168c25cR91

  • try doing a contribution where you disconnect internet in between
  • make sure that contribution finishes when you connect internet again (if nothing happens try restarting browser as this will retry it as well)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Notes

Will be also adding flags for QA as wel brave/brave-browser#2102

tmancey
tmancey previously approved these changes Nov 12, 2018
@NejcZdovc NejcZdovc merged commit 6a69932 into master Nov 13, 2018
@NejcZdovc NejcZdovc deleted the contribution-retries branch November 13, 2018 05:10
NejcZdovc added a commit that referenced this pull request Nov 13, 2018
Adds retries into contribution flow for rewards
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Nov 13, 2018

master (0.59) 6a69932
0.58.x dc2e088
0.57.x 0743544

@srirambv
Copy link
Contributor

srirambv commented Nov 13, 2018

Uplift to 0.57.x approved by @rebron and @kjozwiak . Verified the PR works great 🥇

NejcZdovc added a commit that referenced this pull request Nov 13, 2018
Adds retries into contribution flow for rewards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add retries to contribution Failed contribution notification for donations
5 participants