Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made custom ads popup respects light/dark mode on linux. #9337

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Made custom ads popup respects light/dark mode on linux. #9337

merged 1 commit into from
Jul 7, 2021

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Jul 5, 2021 •
edited
Loading

Browser on linux uses system theme if no parent/context is set for widget
on creation. So instead of getting theme through GetNativeTheme() method
use GetActiveBraveDarkModeType().

Resolves brave/brave-browser#16234

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@aseren aseren requested a review from a team as a code owner July 5, 2021 15:42
@aseren aseren force-pushed the custom_ads_dark_theme branch 2 times, most recently from fcff1c2 to bbb2d0e Compare July 6, 2021 13:03
@aseren aseren changed the title Made custom ads popup respects light/dark mode settings. Made custom ads popup respects light/dark mode on linux. Jul 6, 2021
@aseren
Made custom ads popup respects light/dark mode on linux.
4d6648e 
Browser on linux uses system theme if no parent/context is set for widget
on creation. So instead of getting theme through GetNativeTheme() method
use GetActiveBraveDarkModeType().
fix brave/brave-browser#16234
@aseren aseren force-pushed the custom_ads_dark_theme branch from bbb2d0e to 4d6648e Compare July 6, 2021 13:06
@aseren aseren requested a review from tmancey July 6, 2021 13:12
tmancey
tmancey approved these changes Jul 6, 2021
View reviewed changes
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@aseren aseren merged commit dc5ade6 into master Jul 7, 2021
@aseren aseren deleted the custom_ads_dark_theme branch July 7, 2021 16:27
@tmancey tmancey added this to the 1.28.x - Nightly milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iefremov iefremov iefremov approved these changes

@tmancey tmancey tmancey approved these changes

Assignees

@aseren aseren

Labels
None yet
Projects
None yet
Milestone
1.28.x - Release
Development

Successfully merging this pull request may close these issues.

Custom ad notifications do not respect dark mode on Linux
3 participants
@aseren @tmancey @iefremov