-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show sync setup error #951
Conversation
I see 3 failed browser tests
|
There is a separate issue for ui design for the error message: brave/brave-browser#2128. So this PR address brave/brave-browser#2103 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, could you squash 1397cb1cf6a7f126edb1ab3479bf7f9b14034ef3 (1) and 01983484e2e0044ee20da721515628763b288f53 (4) into b94973a6cd4c4cdb1a7c8ffa23b898c3f5c597e7 (2)? And I will approve
@AlexeyBarabash please change the word in the PR comment to |
fixed typo in log message
0198348
to
5a4fb10
Compare
@darkdh , squashed commits, also rebased the branch to today's master. |
Address brave/brave-browser#2103 .
This is PR for brave/brave-browser#2103 and for
Expected results pt2
for brave/brave-browser#2130 .Contains required native-code changes, but does not close the issue entirely.
Issue still require to proper implement of
in
components/brave_sync/ui/brave_sync.tsx
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
wrong code words
Reviewer Checklist: