Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localization after order #960

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Update localization after order #960

merged 1 commit into from
Nov 27, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Nov 27, 2018

Fix brave/brave-browser#2254

Note there's a small param tweak which I think does nothing, but makes the mode explicit to indicate to include untranslated strings too. (script/lib/transifex.py)

@bbondy bbondy requested a review from emerick November 27, 2018 15:02
emerick
emerick previously approved these changes Nov 27, 2018
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit 9ae6600 into master Nov 27, 2018
bbondy added a commit that referenced this pull request Nov 27, 2018
Update localization after order
@bbondy
Copy link
Member Author

bbondy commented Nov 27, 2018

master: 9ae6600
0.58.x: a03cc5f
0.57.x: bb3ba17

bbondy added a commit that referenced this pull request Nov 27, 2018
Update localization after order
@bbondy bbondy deleted the l10n-update branch December 5, 2018 15:28
@bbondy bbondy added this to the 0.57.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants