handle multiple error cases for sync #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
requested changes
Nov 28, 2018
cezaraugusto
force-pushed
the
ca-sync--setup-err
branch
2 times, most recently
from
6b766be to
6233226
Compare
darkdh
reviewed
Nov 28, 2018
cezaraugusto
force-pushed
the
ca-sync--setup-err
branch
from
6233226 to
06bbfc0
Compare
fix brave/brave-browser#2103 - error states added: - no internet - wrong sync words - empty sync words - missing device name
cezaraugusto
force-pushed
the
ca-sync--setup-err
branch
from
06bbfc0 to
074b346
Compare
darkdh
approved these changes
Nov 30, 2018
There was a problem hiding this comment.
++, ERR_SYNC_INIT_FAILED will be handled as follow-up
brave/brave-browser#2316
cezaraugusto
added a commit
that referenced
this pull request
Nov 30, 2018
handle multiple error cases for sync
cezaraugusto
added a commit
that referenced
this pull request
Nov 30, 2018
handle multiple error cases for sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#2103
error states added:
Test Plan:
brave --enable-brave-syncbrave://bravesync/I have an existing sync codeCase 1 - No internet connection
Case 2 - Wrong code phrase
noise elite faculty between enforce soul happy talk nut anxiety minute flower follow cradle act road hollow lazy unlock glove brush pepper buyer wrongwordCase 3 - Empty Code Phrase
Case 4 - No device name
borrow other exile curve inflict monster jacket piece shrug spider shock clip art describe task fancy odor such bargain legal embody sibling course labor