Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Brave ads estimated earnings do not reconcile after a users wallet has changed through restore or corruption - 1.28.x #9749

Closed
wants to merge 1 commit into from
Closed

Fixes Brave ads estimated earnings do not reconcile after a users wallet has changed through restore or corruption - 1.28.x #9749

wants to merge 1 commit into from

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 13, 2021

Uplift of #9714
Resolves brave/brave-browser#17412

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey
Fixes Brave ads estimated earnings do not reconcile after a users wal…
0a59762 
…let has changed through restore or corruption
@tmancey tmancey requested a review from a team August 13, 2021 18:14
@tmancey tmancey self-assigned this Aug 13, 2021
@tmancey tmancey added this to the 1.28.x - Release #2 milestone Aug 13, 2021
@kjozwiak
Copy link
Member

Restarting macOS due to build failing as per https://ci.brave.com/job/pr-brave-browser-issues-17412-1.28.x-macos/1/execution/node/140/log/.

FAILED: obj/chrome/browser/extensions/extensions/allowlist.o

@kjozwiak
Copy link
Member

Going to close this off after speaking with @jsecretan. We'll just include this in 1.29.x via #9745.

@kjozwiak kjozwiak closed this Aug 18, 2021
@kjozwiak kjozwiak removed the request for review from a team August 18, 2021 17:23
@kjozwiak kjozwiak removed this from the 1.28.x - Release #2 milestone Aug 18, 2021
@kjozwiak kjozwiak deleted the issues/17412-1.28.x branch August 18, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak