[cr93 followup] Fix for webtorrent crash. #9858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#17652
This is an upstream bug introduced in this Chromium change:
https://source.chromium.org/chromium/chromium/src/+/301dd60948a8b3a628cf6bd3a0f9da0ab91743ef
commit 301dd60948a8b3a628cf6bd3a0f9da0ab91743ef
Author: Nicolas Ouellet-Payeur nicolaso@chromium.org
Date: Tue Jun 15 13:43:57 2021 +0000
The bug is that the SocketsTcpServerGetInfoFunction::Work was changed to
get args into local variable params, but then the instance variable
params_ was left to be used in the rest of the menthod's code.
The fix has already been merged upstream but has not made it to Cr93
yet:
https://chromium.googlesource.com/chromium/src/+/427152d3d98fce04457af56b0c362c45eb1ec042
commit 427152d3d98fce04457af56b0c362c45eb1ec042
Author: Reilly Grant reillyg@chromium.org
Date: Tue Aug 24 22:29:18 2021 +0000
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: