Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17692 - Add messaging in the UI about 5% tipping fee when tipping (uplift to 1.29.x) #9891

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Fix #17692 - Add messaging in the UI about 5% tipping fee when tipping (uplift to 1.29.x) #9891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions browser/ui/webui/brave_webui_source.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,6 +963,7 @@ void CustomizeWebUIHTMLSource(const std::string &name,
{ "monthlyText", IDS_BRAVE_UI_MONTHLY_TEXT },
{ "nextContributionDate", IDS_BRAVE_REWARDS_TIP_NEXT_CONTRIBUTION_DATE }, // NOLINT
{ "notEnoughTokens", IDS_BRAVE_REWARDS_TIP_NOT_ENOUGH_TOKENS },
{ "tippingFeeNote", IDS_BRAVE_REWARDS_TIPPING_FEE_NOTE },
{ "on", IDS_BRAVE_UI_ON },
{ "onboardingMaybeLater", IDS_BRAVE_REWARDS_ONBOARDING_MAYBE_LATER },
{ "onboardingSetupAdsHeader", IDS_BRAVE_REWARDS_ONBOARDING_SETUP_ADS_HEADER }, // NOLINT
Expand Down
7 changes: 7 additions & 0 deletions components/brave_rewards/resources/tip/components/bat_tip_form.style.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,10 @@ export const notEnoughFunds = styled.div`
color: var(--brave-palette-neutral300);
}
`

export const feeNote = styled.div`
text-align: center;
font-size: 11px;
line-height: 16px;
color: var(--brave-palette-neutral600);
`
3 changes: 3 additions & 0 deletions components/brave_rewards/resources/tip/components/bat_tip_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ export function BatTipForm (props: Props) {
</style.main>
<style.footer>
<style.terms>
<style.feeNote>
{getString('tippingFeeNote')}
</style.feeNote>
<TermsOfService />
</style.terms>
{
Expand Down
1 change: 1 addition & 0 deletions components/brave_rewards/resources/tip/stories/locale_strings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export const localeStrings = {
supportThisCreator: 'Support this creator',
thanksForTheSupport: 'Thanks for the support!',
tipHasBeenSent: 'Your one-time tip has been sent.',
tippingFeeNote: 'Brave collects 5% of the tip amount as a processing fee.',
tipPostSubtitle: 'for their post',
tokens: 'tokens',
tweetAboutSupport: 'Tweet about your support',
Expand Down
1 change: 1 addition & 0 deletions components/resources/brave_components_strings.grd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,7 @@
<message name="IDS_BRAVE_REWARDS_TIP_MONTHLY_CONTRIBUTION_SET" desc="">Monthly contribution has been set.</message>
<message name="IDS_BRAVE_REWARDS_TIP_NEXT_CONTRIBUTION_DATE" desc="">Next contribution date:</message>
<message name="IDS_BRAVE_REWARDS_TIP_NOT_ENOUGH_TOKENS" desc="">Not enough tokens. Please <ph name="LINK_BEGIN">$1</ph>add funds<ph name="LINK_END">$2</ph>.</message>
<message name="IDS_BRAVE_REWARDS_TIPPING_FEE_NOTE" desc="">Brave collects 5% of the tip amount as a processing fee.</message>
<message name="IDS_BRAVE_REWARDS_TIP_ONE_TIME_TIP" desc="">One-Time Tip</message>
<message name="IDS_BRAVE_REWARDS_TIP_ONE_TIME_TIP_AMOUNT" desc="">One-time tip amount:</message>
<message name="IDS_BRAVE_REWARDS_TIP_OPT_IN_REQUIRED" desc="">Hold on, you can’t tip yet</message>
Expand Down