Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rewards notification for insufficient funds #993

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Nov 30, 2018

Fixes brave/brave-browser#1479
Requires brave/brave-ui#301

Notify the user about upcoming contribution when they don't have
enough funds to cover the donations. The notification occurs 3 days
before the contribution will be made.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • Delete any existing profile
  • Launch Brave
  • Enable Rewards
  • Ensure that existing balance is less than contribution amount
  • Wait > 1 day (every day, we check if notifications need to be displayed)
  • Rewards icon should be badged and should contain a notification like this:

image

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@emerick emerick self-assigned this Nov 30, 2018
@NejcZdovc
Copy link
Contributor

@emerick can you please rebase

@emerick emerick force-pushed the rewards-insufficient-funds-notification branch from edd094f to 972e683 Compare December 3, 2018 14:02
@emerick
Copy link
Contributor Author

emerick commented Dec 3, 2018

@emerick can you please rebase

Done!

@emerick emerick force-pushed the rewards-insufficient-funds-notification branch 3 times, most recently from 95b5e39 to 3884877 Compare December 4, 2018 01:33
@NejcZdovc
Copy link
Contributor

this one is currently blocked on 0.35 version of UI to be added.

@emerick emerick force-pushed the rewards-insufficient-funds-notification branch from 3884877 to 51822ac Compare December 4, 2018 15:35
@emerick emerick force-pushed the rewards-insufficient-funds-notification branch 4 times, most recently from f46c974 to 0493f41 Compare December 18, 2018 20:06
Notify the user about upcoming contribution when they don't have
enough funds to cover the donations. The notification occurs 3 days
before the contribution will be made.
@emerick emerick force-pushed the rewards-insufficient-funds-notification branch from 0493f41 to 6768c26 Compare December 19, 2018 14:04
@NejcZdovc NejcZdovc merged commit 3f3d57c into master Dec 19, 2018
@NejcZdovc NejcZdovc deleted the rewards-insufficient-funds-notification branch December 19, 2018 14:23
NejcZdovc added a commit that referenced this pull request Dec 19, 2018
…ation

Add rewards notification for insufficient funds
@NejcZdovc
Copy link
Contributor

master (0.61) 3f3d57c
0.60 b0faacc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 3 day balance notification
3 participants