-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rewards notification for insufficient funds #993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
reviewed
Dec 2, 2018
components/brave_rewards/resources/extension/brave_rewards/components/panel.tsx
Outdated
Show resolved
Hide resolved
@emerick can you please rebase |
emerick
force-pushed
the
rewards-insufficient-funds-notification
branch
from
December 3, 2018 14:02
edd094f
to
972e683
Compare
Done! |
emerick
force-pushed
the
rewards-insufficient-funds-notification
branch
3 times, most recently
from
December 4, 2018 01:33
95b5e39
to
3884877
Compare
this one is currently blocked on 0.35 version of UI to be added. |
emerick
force-pushed
the
rewards-insufficient-funds-notification
branch
from
December 4, 2018 15:35
3884877
to
51822ac
Compare
NejcZdovc
reviewed
Dec 17, 2018
components/brave_rewards/resources/extension/brave_rewards/components/panel.tsx
Outdated
Show resolved
Hide resolved
NejcZdovc
reviewed
Dec 17, 2018
emerick
force-pushed
the
rewards-insufficient-funds-notification
branch
4 times, most recently
from
December 18, 2018 20:06
f46c974
to
0493f41
Compare
NejcZdovc
reviewed
Dec 19, 2018
components/brave_rewards/resources/extension/brave_rewards/background/api/locale_api.ts
Show resolved
Hide resolved
NejcZdovc
reviewed
Dec 19, 2018
Notify the user about upcoming contribution when they don't have enough funds to cover the donations. The notification occurs 3 days before the contribution will be made.
emerick
force-pushed
the
rewards-insufficient-funds-notification
branch
from
December 19, 2018 14:04
0493f41
to
6768c26
Compare
NejcZdovc
approved these changes
Dec 19, 2018
NejcZdovc
added a commit
that referenced
this pull request
Dec 19, 2018
…ation Add rewards notification for insufficient funds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#1479
Requires brave/brave-ui#301
Notify the user about upcoming contribution when they don't have
enough funds to cover the donations. The notification occurs 3 days
before the contribution will be made.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: