Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Commit

Permalink
Fix #8190: Add in-page search to the debug histograms controller (#8199)
Browse files Browse the repository at this point in the history
  • Loading branch information
kylehickinson authored Oct 5, 2023
1 parent 46d5387 commit 730c22f
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions Sources/Brave/Frontend/Settings/SettingsViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -785,6 +785,22 @@ class SettingsViewController: TableViewController {
let histogramsController = self.p3aUtilities.histogramsController().then {
$0.title = "Histograms (p3a)"
}
if #available(iOS 16.0, *) {
// TODO: Replace this with property access when exposed from brave-core side
let webView = histogramsController.value(forKey: "_webView") as! WKWebView // swiftlint:disable:this force_cast
webView.isFindInteractionEnabled = true
histogramsController.navigationItem.rightBarButtonItem = UIBarButtonItem(
systemItem: .search,
primaryAction: .init { [weak webView] _ in
guard let findInteraction = webView?.findInteraction,
!findInteraction.isFindNavigatorVisible else {
return
}
findInteraction.searchText = ""
findInteraction.presentFindNavigator(showingReplace: false)
}
)
}
self.navigationController?.pushViewController(histogramsController, animated: true)
}, accessory: .disclosureIndicator, cellClass: MultilineValue1Cell.self),
Row(
Expand Down

0 comments on commit 730c22f

Please sign in to comment.