Fix URLs not opening in active-tab

brave · Nov 29, 2023 · b197187 · b197187
1 parent 429742c
commit b197187
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/...e/Frontend/Browser/BrowserViewController/BrowserViewController+WKNavigationDelegate.swift b/...e/Frontend/Browser/BrowserViewController/BrowserViewController+WKNavigationDelegate.swift
@@ -852,7 +852,7 @@ extension BrowserViewController {
     // Finally check non-active tab
     let isNonActiveTab = isAboutHome ? false : tab?.url?.host != topToolbar.currentURL?.host
 
-    if !isMainFrame || isNonActiveTab {
+    if !isMainFrame && isNonActiveTab {
       openedURLCompletionHandler?(false)
       return
     }
@@ -903,7 +903,13 @@ extension BrowserViewController {
         }
       }
       popup.addButton(title: Strings.openExternalAppURLAllow, type: .primary) { [weak tab] () -> PopupViewDismissType in
-        openedURLCompletionHandler?(true)
+        if UIApplication.shared.canOpenURL(url) {
+          UIApplication.shared.open(url, options: [:]) { didOpen in
+            openedURLCompletionHandler?(!didOpen)
+          }
+        } else {
+          openedURLCompletionHandler?(true)
+        }
         removeTabIfEmpty()
         tab?.isExternalAppAlertPresented = false
         return .flyDown