Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Shouldn't be able to join expired Sync chain #4663

Closed
stephendonner opened this issue Dec 8, 2021 · 1 comment
Closed

Shouldn't be able to join expired Sync chain #4663

stephendonner opened this issue Dec 8, 2021 · 1 comment

Comments

@stephendonner
Copy link
Contributor

stephendonner commented Dec 8, 2021

Description:

Shouldn't be able to join expired Sync chain

This is a followup issue from brave/brave-browser#19550.

Steps to Reproduce

  1. Create a Sync chain on Desktop and keep it open until Step 6 is done.
  2. Wait 20 minutes / forward system clock on both iOS and Desktop.
  3. Attempt to join Sync chain on iOS (it should WORK, and DOES).
  4. Reset iOS profile (reinstall).
  5. Wait 11 minutes (so that it’s > 30 minutes since generating the code) / forward system clock again on both iOS and Desktop.
  6. Attempt to join Sync chain on iOS (it should FAIL, but WORKS).

Actual result:

Able to join the Sync chain from iOS

Image from iOS (4)

Expected result:

Should see Code expired or similar

Reproduces how often: [Easily reproduced, Intermittent Issue]
100% (maybe I'm doing this wrong?)

Brave Version:
1.33 (21.12.7.21)

Device details:
iPhone 6s (iOS 15.0.2)

cc @brave/legacy_qa

@stephendonner
Copy link
Contributor Author

Got this working; did it without forwarding the system clock, and got the following expected dialog:

Image from iOS

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants