-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to sync QR code #19550
Comments
|
Verified on https://github.com/brave/brave-browser/releases/tag/v1.35.1, preparing uplift to 1.33.x |
Uplift PR created brave/brave-core#11358 |
Removing |
Verified
Cross-timezone tests -
|
example | example | example | example |
---|---|---|---|
[image missing; corrupted while uploading to GitHub. Not retesting for sake of time.] |
Desktop & iOS - PASSED
example | example | example | example | example | example |
---|---|---|---|---|---|
iOS & Android - PASSED
example | example | example | example | example | example |
---|---|---|---|---|---|
Normal expiration test - PASSED
- create a Sync chain on Desktop and keep it open until Step 6 is done.
- wait 20 minutes.
- attempt to join Sync chain on Android (it should WORK).
- reset Android profile.
- wait 11 minutes (so that it’s > 30 minutes since generating the code).
- attempt to join Sync chain on Android (it should FAIL)
- repeat these steps with two Android phones and no Desktop (NOTE: unable to test; only have a single Android test device)
- repeat these steps with a Desktop and an iOS phone.
- repeat these steps with an iOS phone as the Sync chain creator and an Android phone as the Sync chain joiner
Desktop & Android - PASSED
example | example | example |
---|---|---|
Desktop & iOS - PASSED
example | example | example |
---|---|---|
iOS & Android - PASSED
Verification done over in #19550 (comment)
Code expiring too far into the future - PASSED
- set up a desktop computer and change the date to 1 day into the future.
- set up an Android phone with the correct date and time.
- create a Sync chain on Desktop.
- attempt to join the Sync chain on Android (it should FAIL)
- attempt to join the same Sync chain on iOS (it should FAIL)
example | example | example |
---|---|---|
Old-style QR codes - PASSED
- set up a desktop computer with an earlier version of Brave (with the old-style QR codes).
- set up an Android phone with support for updated QR codes.
- create a Sync chain on Desktop.
- attempt to join the Sync chain on Android (it should WORK).
- reset both browser profiles.
- change time on desktop computer to January 2nd 2022.
- change time on Android phone to January 2nd 2022.
- create a Sync chain on Desktop.
- attempt to join the Sync chain on Android (it should FAIL).
- repeat these steps with an iOS phone instead of an Android one.
Desktop & Android - PASSED
example | example | example | example |
---|---|---|---|
Desktop & iOS - PASSED
example | example | example | example |
---|---|---|---|
Malformed QR codes (Android & desktop) - PASSED
Verified using Android 1 - Google Pixel (Android 11) Verified cases listed in doc from https://github.com/brave/internal/issues/832#issuecomment-973471650 for Android <--> Android sync. Cross-timezone tests - PASSED
Confirmed able to join sync chains as expected in steps 4 and 7.
Normal expiration test - PASSED
Code expiring too far into the future - PASSED
Old-style QR codes - PASSED
Note - Malformed QR Codes were tested on Android by @stephendonner with #19550 (comment). Verified using iOS 1 - iPhone 6s Plus (iOS 15.1) Verified cases listed in doc from https://github.com/brave/internal/issues/832#issuecomment-973471650 for iOS <--> iOS sync. Cross-timezone tests - PASSED
Initially to join sync chains as expected in steps 4 and 7, logged brave/brave-ios#4662.
Normal expiration test - PASSED
Code expiring too far into the future - PASSED
Old-style QR codes - PASSED
Using Malformed QR codes/Malformed JSON (iOS) - PASSEDScanned example Malformed QR Codes from spec, confirmed error message was received.
|
Verification
Cross-timezone tests -
|
example | example | example | example |
---|---|---|---|
Desktop & iOS - PASSED
example | example | example | example |
---|---|---|---|
iOS & Android - PASSED
example | example | example | example | example | example |
---|---|---|---|---|---|
Normal expiration test - PASSED
- create a Sync chain on Desktop and keep it open until Step 6 is done.
- wait 20 minutes.
- attempt to join Sync chain on Android (it should WORK).
- reset Android profile.
- wait 11 minutes (so that it’s > 30 minutes since generating the code).
- attempt to join Sync chain on Android (it should FAIL)
- repeat these steps with two Android phones and no Desktop (NOTE: unable to test; only have a single Android test device)
- repeat these steps with a Desktop and an iOS phone.
- repeat these steps with an iOS phone as the Sync chain creator and an Android phone as the Sync chain joiner
Desktop & Android - PASSED
example | example | example |
---|---|---|
Desktop & iOS - PASSED
example | example | example |
---|---|---|
iOS & Android - PASSED
example | example | example | example |
---|---|---|---|
Code expiring too far into the future - PASSED
- set up a desktop computer and change the date to 1 day into the future.
- set up an Android phone with the correct date and time.
- create a Sync chain on Desktop.
- attempt to join the Sync chain on Android (it should FAIL)
- attempt to join the same Sync chain on iOS (it should FAIL)
example | example | example |
---|---|---|
Old-style QR codes - PASSED
- set up a desktop computer with an earlier version of Brave (with the old-style QR codes).
- set up an Android phone with support for updated QR codes.
- create a Sync chain on Desktop.
- attempt to join the Sync chain on Android (it should WORK).
- reset both browser profiles.
- change time on desktop computer to January 2nd 2022.
- change time on Android phone to January 2nd 2022.
- create a Sync chain on Desktop.
- attempt to join the Sync chain on Android (it should FAIL).
- repeat these steps with an iOS phone instead of an Android one.
Desktop & Android - PASSED
example | example | example | example |
---|---|---|---|
Desktop & iOS - PASSED
example | example | example | example |
---|---|---|---|
Going to re-do the macOS section for (and fixed) the testcase |
Verification passed on
Cross-timezone tests -
|
Desktop & iOS - PASSED
Normal expiration test - PASSED
- create a Sync chain on Desktop and keep it open until Step 6 is done.
- wait 20 minutes.
- attempt to join Sync chain on Android (it should WORK).
- reset Android profile.
- wait 11 minutes (so that it’s > 30 minutes since generating the code).
- attempt to join Sync chain on Android (it should FAIL)
- repeat these steps with two Android phones and no Desktop (NOTE: unable to test; only have a single Android test device)
- repeat these steps with a Desktop and an iOS phone.
- repeat these steps with an iOS phone as the Sync chain creator and an Android phone as the Sync chain joiner
Desktop & Android - PASSED
Desktop & iOS - PASSED
Code expiring too far into the future - PASSED
- set up a desktop computer and change the date to 1 day into the future.
- set up an Android phone with the correct date and time.
- create a Sync chain on Desktop.
- attempt to join the Sync chain on Android (it should FAIL)
- attempt to join the same Sync chain on iOS (it should FAIL)
Old-style QR codes - PASSED
- set up a desktop computer with an earlier version of Brave (with the old-style QR codes).
- set up an Android phone with support for updated QR codes.
- create a Sync chain on Desktop.
- attempt to join the Sync chain on Android (it should WORK).
- reset both browser profiles.
- change time on desktop computer to January 2nd 2022.
- change time on Android phone to January 2nd 2022.
- create a Sync chain on Desktop.
- attempt to join the Sync chain on Android (it should FAIL).
- repeat these steps with an iOS phone instead of an Android one.
Desktop & Android - PASSED
Desktop & iOS - PASSED
Description:
See https://github.com/brave/internal/issues/832
The text was updated successfully, but these errors were encountered: