[release] Ref #8076: Bump brave-core to 1.59.124. #8311

iccub · 2023-10-25T18:17:04Z

Summary of Changes

This pull request fixes #

Unit Tests are updated to cover new or changed functionality
User-facing strings use NSLocalizableString()
New or updated UI has been tested across:
- Light & dark mode
- Different size classes (iPhone, landscape, iPad)
- Different dynamic type sizes

Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
Necessary security reviews have taken place.
Adequate unit test coverage exists to prevent regressions.
Adequate test plan exists for QA to validate (if applicable).
Issue and pull request is assigned to a milestone (should happen at merge time).

soner-yuksel · 2023-10-25T19:35:43Z

Has quite some unresolved Adblock changes

iccub · 2023-10-25T19:39:00Z

yes @soner-yuksel some changes required. Jacob handles this
same has to be done on development branch soon

…8312) Fix #8100: Use proper ad-block components

[release] Bump brave-core to 1.59.124.

dc04d2c

iccub added the QA/No label Oct 25, 2023

iccub requested a review from a team as a code owner October 25, 2023 18:17

Uplift of #8100: Use proper ad-block components (uplift to 1.59.x) (#…

febca93

…8312) Fix #8100: Use proper ad-block components

soner-yuksel approved these changes Oct 25, 2023

View reviewed changes

iccub changed the title ~~[release] Bump brave-core to 1.59.124.~~ [release] Ref #8076: Bump brave-core to 1.59.124. Oct 25, 2023

iccub added this to the 1.59 milestone Oct 25, 2023

iccub merged commit 3d5d538 into release Oct 25, 2023
5 checks passed

iccub deleted the bump/1.59.124 branch October 25, 2023 20:42