Enable debounce at 5 percent on nightly #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzhaller
approved these changes
Sep 24, 2021
add min_version
pilgrim-brave
force-pushed
the
mpilgrim_debounce_5
branch
from
28e7906 to
8a08e3c
Compare
iefremov
reviewed
Sep 24, 2021
| } | ||
| ], | ||
| "filter": { | ||
| "min_version": "94.0.4606.54", |
There was a problem hiding this comment.
@pilgrim-brave @moritzhaller this is a wrong version format, see other entries
There was a problem hiding this comment.
Well I see them. Is there a way to get the version in that format from, say, a Brave Nightly build?
There was a problem hiding this comment.
it is shown on brave://system for example. Or you manually craft it by taking chromium major version (aka 94) and appending brave version (e.g. 1.31.55)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature is described here: brave/brave-browser#15090