Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable cookie dialog blocking list on Nightly #268

Closed
wants to merge 1 commit into from

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Jun 2, 2022

Issues with a handful of websites were resolved with changes in brave-core. This PR re-enables the list by default on Nightly as per discussion on https://bravesoftware.slack.com/archives/C6YNM6Y5S/p1654120574558859?thread_ts=1654117214.714209&cid=C6YNM6Y5S

@antonok-edm antonok-edm self-assigned this Jun 2, 2022
@antonok-edm antonok-edm requested a review from a team as a code owner June 2, 2022 04:21
@antonok-edm antonok-edm force-pushed the re-enable-cookie-list branch from 703c4fb to 74bb0f0 Compare June 2, 2022 16:30
@antonok-edm antonok-edm changed the title Re-enable cookie dialog blocking list on Nightly and Beta Re-enable cookie dialog blocking list on Nightly Jun 2, 2022
@antonok-edm
Copy link
Collaborator Author

Updated to just enable on Nightly, at least until brave/brave-core#12827 makes it to Beta.

@kjozwiak
Copy link
Member

kjozwiak commented Jun 9, 2022

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.41.50 Chromium: 102.0.5005.99 (Official Build) nightly (64-bit)
-- | --
Revision | 870f7bcc58dfa811cc68c2186439721385e086d0-refs/branch-heads/5005@{#1125}
OS | Windows 11 Version 21H2 (Build 22000.708)

Launched 1.41.50 Chromium: 102.0.5005.99 using --variations-server-url=https://variations.bravesoftware.com/seed and ensured that Easylist-Cookie List - Filter Obtrusive Cookie Notices was enabled via brave://adblock.

Example (Before Change) Example (After Change)
image launchingFlag

@kjozwiak
Copy link
Member

kjozwiak commented Jun 9, 2022

Verified as per #268 (comment) and ready to merge. However, the above is pending further discussion. Adding the Uplift/Blocked label.

@kjozwiak
Copy link
Member

@antonok-edm should we close this off for now till we have more info? Seems like we're going to need some client side changes re: having modals that let users enable this feature themselves rather than us doing it by default. I don't mind leaving this opened either. Let me know what works for you 👍

@kjozwiak
Copy link
Member

Going to close this off as we're going to go with the approach of adding a modal/some type of user interaction that will let them enable the list when Brave detects a cookie permission modal.

@kjozwiak kjozwiak closed this Jun 29, 2022
@kjozwiak kjozwiak deleted the re-enable-cookie-list branch June 29, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants