Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Fixed dnd for tabs
Browse files Browse the repository at this point in the history
Resolves #6033

Auditors: @bsclifton

Test Plan:
- try dnd tabs as mentioned in #6033
  • Loading branch information
NejcZdovc committed Jan 22, 2017
1 parent 94f8976 commit 2241a04
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion js/dnd.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ module.exports.onDragOver = (dragType, sourceBoundingRect, draggingOverKey, drag

e.preventDefault()
e.dataTransfer.dropEffect = 'move'
// Otherise, only accept it if we have some frameProps
// Otherwise, only accept it if we have some frameProps
if (!dndData.hasDragData(e.dataTransfer, dragType)) {
windowActions.setIsBeingDraggedOverDetail(dragType, draggingOverKey, {
draggingOverLeftHalf: false,
Expand Down
2 changes: 1 addition & 1 deletion js/dndData.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
const Immutable = require('immutable')

module.exports.hasDragData = (dataTransfer, dragType) => {
return !!dataTransfer.getData(`application/x-brave-${dragType}`)
return dataTransfer.types.includes(`application/x-brave-${dragType}`)
}

module.exports.getDragData = (dataTransfer, dragType) => {
Expand Down

0 comments on commit 2241a04

Please sign in to comment.