This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Probably a merge problem that you ran into Auditors: @bridiver Introduced here: 7280390 It was causing the close button to render wrongly and also failing automated unit tests on the downloads bar
- Loading branch information
2c55150
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure this is correct? I pulled in what we had in master
https://github.com/brave/browser-laptop/blob/master/js/components/downloadsBar.js#L137
8caa528
2c55150
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbondy I think it should be just
<Button className='hideDownloadsToolbar downloadButton'
..hideDownloadsToolbar
did not exist in 8caa5282c55150
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created a PR: #6153