Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Fix hide download toolbar button
Browse files Browse the repository at this point in the history
Probably a merge problem that you ran into

Auditors: @bridiver

Introduced here: 7280390

It was causing the close button to render wrongly and also failing automated unit tests on the downloads bar
  • Loading branch information
bbondy committed Dec 12, 2016
1 parent 98dfbd1 commit 2c55150
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion app/renderer/components/downloadsBar.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ class DownloadsBar extends ImmutableComponent {
}
</div>
<div className='downloadBarButtons'>
<Button className='downloadButton'
<Button iconClass='fa-times'
className='hideDownloadsToolbar downloadButton smallButton hideButton'
onClick={this.onHideDownloadsToolbar} />
</div>
</div>
Expand Down

3 comments on commit 2c55150

@bridiver
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this is correct? I pulled in what we had in master
https://github.com/brave/browser-laptop/blob/master/js/components/downloadsBar.js#L137
8caa528

@luixxiul
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbondy I think it should be just <Button className='hideDownloadsToolbar downloadButton'.

.hideDownloadsToolbar did not exist in 8caa528

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented on 2c55150 Dec 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created a PR: #6153

Please sign in to comment.