Delete "defaultBrowserCheckComplete" only when check on startup is on

fix #4934 Auditors: @bbondy Test Plan: 1. Turn off always check on startup 2. Close app 3. Open app 4. Go to preferences 5. Toggle the switch for always check on startup
brave · Oct 19, 2016 · 449e40d · 449e40d
1 parent 497ecf8
commit 449e40d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/renderer/components/checkDefaultBrowserDialog.js b/app/renderer/components/checkDefaultBrowserDialog.js
@@ -26,11 +26,13 @@ class CheckDefaultBrowserDialog extends ImmutableComponent {
     appActions.defaultBrowserUpdated(false)
     appActions.defaultBrowserCheckComplete()
     appActions.changeSetting(settings.CHECK_DEFAULT_ON_STARTUP, this.props.checkDefaultOnStartup)
+    this.props.onHide()
   }
   onUseBrave () {
     appActions.defaultBrowserUpdated(true)
     appActions.defaultBrowserCheckComplete()
     appActions.changeSetting(settings.CHECK_DEFAULT_ON_STARTUP, this.props.checkDefaultOnStartup)
+    this.props.onHide()
   }
   render () {
     return <Dialog className='checkDefaultBrowserDialog' >

diff --git a/app/sessionStore.js b/app/sessionStore.js
@@ -234,8 +234,10 @@ module.exports.cleanAppData = (data, isShutdown) => {
   data.temporarySiteSettings = {}
   // Delete Flash state since this is checked on startup
   delete data.flashInitialized
-  // Delete defaultBrowserCheckComplete state since this is checked on startup
-  delete data.defaultBrowserCheckComplete
+  if (data.settings[settings.CHECK_DEFAULT_ON_STARTUP] === true) {
+    // Delete defaultBrowserCheckComplete state since this is checked on startup
+    delete data.defaultBrowserCheckComplete
+  }
   // Delete Recovery status on shut down
   try {
     delete data.ui.about.preferences.recoverySucceeded