(unit test update) Value returned by mocked getSettings is now config…

…urable

Auditors: @NejcZdovc

test/unit/app/renderer/components/navigation/navigatorTest.js

@@ -1,14 +1,14 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
-/* global describe, before, after, it */
+/* global describe, before, beforeEach, after, it */
 
 require('../../../../braveUnit')
 const mockery = require('mockery')
 const {mount} = require('enzyme')
 const assert = require('assert')
 const Immutable = require('immutable')
-let Navigator, windowStore, appStore
+let Navigator, windowStore, appStore, settingDefaultValue
 
 const defaultWindowStore = Immutable.fromJS({
   activeFrameKey: 0,
@@ -77,8 +77,11 @@ describe('Navigator component unit tests', function () {
     mockery.registerMock('../../../common/state/shieldState', {
       braveShieldsEnabled: () => true
     })
+    settingDefaultValue = true
     mockery.registerMock('../../../../js/settings', {
-      getSetting: () => true
+      getSetting: () => {
+        return settingDefaultValue
+      }
     })
     appStore = require('../../../../../../js/stores/appStoreRenderer')
     windowStore = require('../../../../../../js/stores/windowStore')
@@ -95,6 +98,7 @@ describe('Navigator component unit tests', function () {
     before(function () {
       appStore.state = appStoreRenderer
       windowStore.state = defaultWindowStore
+      settingDefaultValue = true
       wrapper = mount(<Navigator />)
     })
 
@@ -126,6 +130,7 @@ describe('Navigator component unit tests', function () {
 
       appStore.state = appState2
       windowStore.state = defaultWindowStore
+      settingDefaultValue = true
       wrapper = mount(<Navigator />)
     })
 
@@ -150,9 +155,10 @@ describe('Navigator component unit tests', function () {
   })
 
   describe('lion badge', function () {
-    before(function () {
+    beforeEach(function () {
       appStore.state = appStoreRenderer
       windowStore.state = defaultWindowStore
+      settingDefaultValue = true
     })
 
     it('lion icon is shown by default', function () {
@@ -167,9 +173,18 @@ describe('Navigator component unit tests', function () {
     })
 
     it('counter is not shown when disabled via settings', function () {
-      mockery.registerMock('../../../../js/settings', {
-        getSetting: () => false
-      })
+      /*
+        Unfortunately, this does not work.
+        My thought was: deregister, reregister, then reinclude Navigator (so it uses updated mock)
+      */
+      // mockery.deregisterMock('../../../../js/settings')
+      // mockery.registerMock('../../../../js/settings', {
+      //   getSetting: () => {
+      //     return false
+      //   }
+      // })
+      // Navigator = require('../../../../../../app/renderer/components/navigation/navigator')
+      settingDefaultValue = false
       const wrapper = mount(<Navigator />)
       assert.equal(wrapper.find('[data-test-id="lionBadge"]').length, 0)
     })