don't send binary data over ipc

auditors: @bbondy
brave · Nov 28, 2016 · 9ed262a · 9ed262a · bbondy · Nov 29, 2016
1 parent 0c46a17
commit 9ed262a
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/app/filtering.js b/app/filtering.js
@@ -140,7 +140,10 @@ function registerForBeforeRequest (session, partition) {
         }
 
         BrowserWindow.getAllWindows().forEach((wnd) =>
-          wnd.webContents.send(message, parentResourceName, details))
+          wnd.webContents.send(message, parentResourceName, {
+            tabId: details.tabId,
+            url: details.url
+          }))
         if (details.resourceType === 'image') {
           cb({ redirectURL: transparent1pxGif })
         } else {
@@ -161,7 +164,10 @@ function registerForBeforeRequest (session, partition) {
             appActions.addResourceCount(results.resourceName, 1)
           }
           BrowserWindow.getAllWindows().forEach((wnd) =>
-            wnd.webContents.send(messages.HTTPSE_RULE_APPLIED, results.ruleset, details))
+            wnd.webContents.send(messages.HTTPSE_RULE_APPLIED, results.ruleset, {
+              tabId: details.tabId,
+              url: details.url
+            }))
         }
         cb({redirectURL: results.redirectURL})
         return