Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Optimize getTopSites #10004

Closed
bbondy opened this issue Jul 16, 2017 · 0 comments
Closed

Optimize getTopSites #10004

bbondy opened this issue Jul 16, 2017 · 0 comments
Assignees
@bbondy
Labels
perf QA/checked-macOS QA/test-plan-specified release-notes/include
Milestone
0.17.19 (Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Jul 16, 2017 •
edited by luixxiul
Loading

Test plan

#10005 (comment)

screen shot 2017-07-15 at 6 27 48 pm

Just normal browsing shows that getTopSites is hit a lot. In particular anytime a favicon is updated and anytime addSite is called when a page loads.

To make matters worse it's called up to every keystroke due to favicon updates in a google doc, and called periodically very frequently on sites like gmail. If you have lots of tabs it can be called by a lot of them.
@bbondy bbondy added this to the 0.18.x (Release Channel) milestone Jul 16, 2017
@bbondy bbondy self-assigned this Jul 16, 2017
bbondy added a commit that referenced this issue Jul 16, 2017
@bbondy
Optimize top sites
6c102c9 
Fix #10004
@bbondy bbondy mentioned this issue Jul 16, 2017
Merged
8 tasks
bbondy added a commit that referenced this issue Jul 16, 2017
@bbondy
Optimize top sites
48c7a8c 
Fix #10004
@bbondy bbondy modified the milestones: 0.18.x (Release Channel), 0.17.17 (Release Channel) Jul 17, 2017
bbondy added a commit that referenced this issue Jul 17, 2017
@bbondy
Optimize top sites
36a3c92 
Fix #10004
@cndouglas cndouglas added the perf label Jul 17, 2017
This was referenced Jul 19, 2017
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
perf QA/checked-macOS QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.17.19 (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @bsclifton @cndouglas @LaurenWags