You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
The Aphrodite library just introduced a minify option (specifically with Khan/aphrodite@7f9f602). Unfortunately, we have checks which rely on the class name and we DO set NODE_ENV = production while doing a build (which triggers this option OR a similar option).
Example of problem
Here's an example of the issue, showing the difference in the same element between two versions of Brave (notice the class attribute is different):
0.17.16:
Test plan
#10165 (comment)
Discovered by @jonathansampson and @kevinlawler while troubleshooting #10029
Our current theory on the root cause:
The Aphrodite library just introduced a minify option (specifically with Khan/aphrodite@7f9f602). Unfortunately, we have checks which rely on the class name and we DO set NODE_ENV = production while doing a build (which triggers this option OR a similar option).
Example of problem
Here's an example of the issue, showing the difference in the same element between two versions of Brave (notice the
class
attribute is different):0.17.16:
0.17.17:
The proposed fix:
Update the following code to check using attributes, not class names:
browser-laptop/app/renderer/components/main/main.js
Line 481 in 2e92a01
The text was updated successfully, but these errors were encountered: