Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

intermittent - audio indicator is not shown #10611

Closed
cezaraugusto opened this issue Aug 21, 2017 · 1 comment · Fixed by #10691
Closed

intermittent - audio indicator is not shown #10611

cezaraugusto opened this issue Aug 21, 2017 · 1 comment · Fixed by #10691
Assignees
@cezaraugusto
Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Aug 21, 2017 •
edited by luixxiul
Loading

Test plan

#10691 (comment)

Sometimes even with audio playing, the tab audio indicator is not shown. Restarting Brave solves the issue. Intermittent issue without proper STR. Labeling as needs investigation.

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS
  • Brave Version (revision SHA): 0.18.23
  • Steps to reproduce: needs investigation
@cezaraugusto cezaraugusto added feature/tabsbar needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels Aug 21, 2017
@cezaraugusto cezaraugusto mentioned this issue Aug 22, 2017
Closed
@cezaraugusto cezaraugusto added this to the 0.20.x (Developer Channel) milestone Aug 22, 2017
@cezaraugusto cezaraugusto self-assigned this Aug 22, 2017
cezaraugusto added a commit that referenced this issue Aug 28, 2017
@cezaraugusto
improve performance for tabs, include intersectionObserver
efeb942 
fix #10611
fix #10582
fix #10544
fix #10509
fix #10123
fix #9998
fix #9398
fix #8414
fix #7925
fix #7730
fix #7301
fix #6957
@cezaraugusto cezaraugusto mentioned this issue Aug 28, 2017
Merged
cezaraugusto added a commit that referenced this issue Aug 29, 2017
@cezaraugusto
improve performance for tabs, include intersectionObserver
7660913 
fix #10611
fix #10582
fix #10544
fix #10509
fix #10123
fix #9998
fix #9398
fix #8414
fix #7925
fix #7730
fix #7301
fix #6957
@srirambv
Copy link
Collaborator

srirambv commented Sep 4, 2017

I believe the issue comes from pinned tabs.
STR

  1. Open YoutTube in a tab
  2. Play any video, ensure the speaker icon is shown
  3. Pin that YouTube tab, ensure the audio indicator is shown
  4. Unpin YouTube tab, audio indicator/speaker is not shown, If there are tab pages, no noisy tabpage indicator
  5. Switch focus on tab pages, speaker icon and noisy tab indicator is shown

@ghost ghost added the sprint/1 label Sep 13, 2017
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
move AudioTabIcon visibility logic to its component
2b611dc 
- migrate condition to be visible to the comonent itself
- skip component test for now
Auditors: @bsclifton
Test plan: AudioTabIcon should behave the same. Note that #10611
is still an issue for the dynamic breakpoint and will be addressed
in a next commit. This only migrates the component logic
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
UI bug fixing
23fcc08 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7925
fix #10544
fix #10123
fix #10509
fix #10582
fix #10611
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
UI bug fixing
7c58204 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
move AudioTabIcon visibility logic to its component
7ab8ed2 
- migrate condition to be visible to the comonent itself
- skip component test for now
Auditors: @bsclifton
Test plan: AudioTabIcon should behave the same. Note that #10611
is still an issue for the dynamic breakpoint and will be addressed
in a next commit. This only migrates the component logic
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
UI bug fixing
2427327 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
UI bug fixing
94ba1a1 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 19, 2017
@cezaraugusto
move AudioTabIcon visibility logic to its component
49bfbdc 
- migrate condition to be visible to the comonent itself
- skip component test for now
Auditors: @bsclifton
Test plan: AudioTabIcon should behave the same. Note that #10611
is still an issue for the dynamic breakpoint and will be addressed
in a next commit. This only migrates the component logic
cezaraugusto added a commit that referenced this issue Sep 19, 2017
@cezaraugusto
UI bug fixing
321281b 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
@luixxiul luixxiul removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Oct 30, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@cezaraugusto @syuan100
move AudioTabIcon visibility logic to its component
55e3a38 
- migrate condition to be visible to the comonent itself
- skip component test for now
Auditors: @bsclifton
Test plan: AudioTabIcon should behave the same. Note that brave#10611
is still an issue for the dynamic breakpoint and will be addressed
in a next commit. This only migrates the component logic
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@cezaraugusto @syuan100
UI bug fixing
ac96632 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix brave#6716
fix brave#7301
fix brave#7730
fix brave#7765
fix brave#7925
fix brave#10123
fix brave#10509
fix brave#10544
fix brave#10582
fix brave#10611
fix brave#10838
This was referenced Dec 20, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Dec 27, 2017
Closed
35 tasks
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

improve tabs performance and UI with this one simple trick brave/browser-laptop
4 participants
@luixxiul @cezaraugusto @srirambv @LaurenWags