Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Check default browser dialog has the invalid background style property #11041

Closed
luixxiul opened this issue Sep 20, 2017 · 0 comments
Closed

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 20, 2017

Test plan

#11044 (comment)


Description

Check default browser dialog does not have the valid background style property.

Steps to Reproduce

  1. Change the default browser from Brave
  2. Open Brave
  3. Open the devtool on the browser level

Actual result:

section__braveIcon: {
backgroundImage: `image-set(url(${braveAbout}) 2x)`,

clipboard01

Expected result:
backgroundImage: -webkit-image-set(url(${braveAbout}) 2x),

Reproduces how often: [What percentage of the time does it reproduce?]
Always

Brave Version

Brave: 0.19.7
rev: c8481a9
Muon: 4.4.16
libchromiumcontent: 61.0.3163.71
V8: 6.1.534.31
Node.js: 7.9.0
Update Channel: Beta
OS Platform: Linux
OS Release: 4.9.0-3-amd64
OS Architecture: x64

Additional Information

Introduced by me with #8443

@luixxiul luixxiul added the bug label Sep 20, 2017
@luixxiul luixxiul added this to the 0.19.x (Beta Channel) milestone Sep 20, 2017
@luixxiul luixxiul self-assigned this Sep 20, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
Fixes brave#11041

Auditors:

Test Plan:
1. Change the default browser from Brave
2. Open Brave
3. Make sure the lion image is displayed on the dialog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.