This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Pinning throws error #11208
Assignees
Labels
Milestone
Comments
8 tasks
|
@NejcZdovc could you check again against 5af92b4 (current 0.20.x latest). I think this is solved already. I can add another check to bulletproof this btw |
|
@cezaraugusto I am still getting this error, but tab is not looking strange anymore and there is no locking. I would add that check just to be sure |
cezaraugusto
added a commit
that referenced
this issue
Nov 7, 2017
Auditors: @NejcZdovc fix #11208 Test Plan: npm run test -- --grep="isFirstFrameKeyIntabPage"
cezaraugusto
added a commit
that referenced
this issue
Nov 7, 2017
Auditors: @NejcZdovc fix #11208 Test Plan: npm run test -- --grep="isFirstFrameKeyIntabPage"
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
Auditors: @NejcZdovc fix brave#11208 Test Plan: npm run test -- --grep="isFirstFrameKeyIntabPage"
34 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
When you pin second tab you get error.
Steps to Reproduce
Actual result:
Expected result:
No error
Reproduces how often: [What percentage of the time does it reproduce?]
100%
Brave Version
about:brave info:
Brave: 0.21.0
V8: 6.1.534.41
rev: c5a903c
Muon: 4.4.25
OS Release: 16.7.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.3.5
libchromiumcontent: 61.0.3163.100
Reproducible on current live release:
Additional Information
The text was updated successfully, but these errors were encountered: