Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger payment history dates are not sorted in DESC order #11300

Closed
srirambv opened this issue Oct 5, 2017 · 1 comment
Closed

Ledger payment history dates are not sorted in DESC order #11300

srirambv opened this issue Oct 5, 2017 · 1 comment
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include suggestion
Milestone
0.23.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Oct 5, 2017 •
edited by bsclifton
Loading

Test plan

See #12069

Description

The rows shown in the payment history are not sorted, they're just displayed in whatever order they are in with `ledger-state.json`. If you manually edit `ledger-state.json` or run the task to add simulated payment history, you can see how it can get out of order

Steps to Reproduce

  1. Build from source
  2. Run npm run add-simulated-payment-history 50
  3. Open payment history, order is oldest to most recent, should be other way around

Brave Version

about:brave info:

All

Reproducible on current live release:

No

BSC: using happy path, you will not experience this. However, if you run the task (in dev environment), it will repro. But that is not 0.19.95

Additional Information
@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
josiah-keller added a commit to josiah-keller/browser-laptop that referenced this issue Nov 18, 2017
@josiah-keller
Reverse payment history order
cb03145 
Fixes brave#11300
@josiah-keller josiah-keller mentioned this issue Nov 18, 2017
Closed
8 tasks
@bsclifton bsclifton changed the title Reorder ledger payment history Ledger payment history dates are not sorted Nov 20, 2017
@bsclifton bsclifton changed the title Ledger payment history dates are not sorted Ledger payment history dates are not sorted in DESC order Nov 20, 2017
josiah-keller added a commit to josiah-keller/browser-laptop that referenced this issue Nov 23, 2017
@josiah-keller
Sort payment history by date
0f7cc0a 
Fixes brave#11300
@josiah-keller josiah-keller mentioned this issue Nov 23, 2017
Merged
8 tasks
@bsclifton bsclifton modified the milestones: Triage Backlog, 0.22.x (Nightly Channel) Nov 24, 2017
@bsclifton bsclifton mentioned this issue Nov 28, 2017
Closed
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator Author

srirambv commented Jun 14, 2018 •
edited by btlechowski
Loading

Verified on Windows x64 using

  • 0.23.8 06c657b
  • muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified with macOS 10.12.6 using

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

This was referenced Jun 19, 2018
Closed
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Jun 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include suggestion
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
7 participants
@bbondy @luixxiul @cezaraugusto @bsclifton @srirambv @LaurenWags @btlechowski