Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move brave/ad-block and brave/tracking-protection deps to muon #11352

Closed
bbondy opened this issue Oct 7, 2017 · 2 comments
Closed

Move brave/ad-block and brave/tracking-protection deps to muon #11352

bbondy opened this issue Oct 7, 2017 · 2 comments
Assignees
@bbondy
Labels
dev-setup muon perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactor/node-removal release-notes/include
Milestone
0.19.x Hotfix 3 (...

Comments

@bbondy
Copy link
Member

bbondy commented Oct 7, 2017 •
edited by luixxiul
Loading

Test plan

#11352 (comment) (See below)

This task:

  • Remove the deps from browser-laptop
  • Add muon DEPS for the 2 repos

Later v2 o this work:

  • Put it on the IO thread
  • Expose an API or use content settings to control ad-block from browser-laptop
    This should solve what is currently the biggest perf jank around page load.
    This also gets us a step closer to node removal.
@bbondy bbondy self-assigned this Oct 7, 2017
bbondy added a commit that referenced this issue Oct 17, 2017
@bbondy
Remove ad-block and tracking-protection libs
290de04 
Instead it is moving to muon

Related to #11352
bbondy added a commit to brave/tracking-protection that referenced this issue Oct 20, 2017
@bbondy
Add in muon build config
7b5fb79 
Related to:
brave/browser-laptop#11352

Auditors: @SergeyZhukovsky
bbondy added a commit to bbondy/hashset-cpp that referenced this issue Oct 20, 2017
@bbondy
Add in muon build config
3177fe4 
Related to:
brave/browser-laptop#11352

Auditors: @SergeyZhukovsky
bbondy added a commit to bbondy/bloom-filter-cpp that referenced this issue Oct 20, 2017
@bbondy
Add in muon build config
08e3d79 
Related to:
brave/browser-laptop#11352

Auditors: @SergeyZhukovsky
bbondy added a commit to brave-experiments/ad-block that referenced this issue Oct 20, 2017
@bbondy
Add in muon build config
0f51cf6 
Related to:
brave/browser-laptop#11352

Auditors: @SergeyZhukovsky
bbondy added a commit to brave/muon that referenced this issue Oct 20, 2017
@bbondy
Move tracking-protection and ad-block to muon
8418246 
Related to:
brave/browser-laptop#11352
bbondy added a commit that referenced this issue Oct 20, 2017
@bbondy
Use ad-block and TP from muon
b68b5b7 
Related to: #11352
This was referenced Oct 20, 2017
Merged
Closed
bbondy added a commit that referenced this issue Oct 20, 2017
@bbondy
Use ad-block and TP from muon
28fc0cb 
Related to: #11352
bbondy added a commit to brave/muon that referenced this issue Oct 23, 2017
@bbondy
Move tracking-protection and ad-block to muon
b69e04a 
Related to:
brave/browser-laptop#11352
bbondy added a commit that referenced this issue Oct 25, 2017
@bbondy
Use ad-block and TP from muon
15a921d 
Related to: #11352
bbondy added a commit that referenced this issue Oct 31, 2017
@bbondy
Update to muon 4.5.11
16f784a 
Fix #11352
@bbondy bbondy mentioned this issue Oct 31, 2017
Merged
8 tasks
@luixxiul
Copy link
Contributor

Do we need QA on this issue or do general regression tests cover this?

@luixxiul luixxiul added needs-info Another team member needs information from the PR/issue opener. release-notes/include labels Oct 31, 2017
@bbondy
Copy link
Member Author

bbondy commented Oct 31, 2017

Just basic spot check on ad-blocking working in general. Also make sure regional adblock list gets loaded. Nothing specific beyond that.

@luixxiul luixxiul added QA/test-plan-specified and removed needs-info Another team member needs information from the PR/issue opener. labels Oct 31, 2017
This was referenced Nov 1, 2017
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Nov 1, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Nov 2, 2017
Closed
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@bbondy @syuan100
Update to muon 4.5.11
0622e7b 
Fix brave#11352
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
dev-setup muon perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactor/node-removal release-notes/include
Projects
None yet
Milestone
0.19.x Hotfix 3 (Release channel)
Development

No branches or pull requests
4 participants
@bbondy @luixxiul @srirambv @LaurenWags