Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix the wrong BEM naming on addFundsWizardAddress.js #11378

Closed
luixxiul opened this issue Oct 9, 2017 · 1 comment
Closed

Fix the wrong BEM naming on addFundsWizardAddress.js #11378

luixxiul opened this issue Oct 9, 2017 · 1 comment
Assignees
@luixxiul
Labels
feature/about-pages QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 9, 2017 •
edited
Loading

Test plan

#11379 (comment)

Description

Polish addFundsWizardAddress.js

Brave Version

about:brave info:

3544244

Reproducible on current live release:

Additional Information
@luixxiul luixxiul added feature/about-pages polish Nice to have — usually related to front-end/visual tasks. labels Oct 9, 2017
@luixxiul luixxiul self-assigned this Oct 9, 2017
@luixxiul luixxiul mentioned this issue Oct 9, 2017
Merged
8 tasks
@luixxiul luixxiul changed the title Polish addFundsWizardAddress.js Fix the wrong BEM naming on addFundsWizardAddress.js Nov 18, 2017
@luixxiul luixxiul removed the polish Nice to have — usually related to front-end/visual tasks. label Nov 18, 2017
cezaraugusto pushed a commit that referenced this issue Nov 21, 2017
@cezaraugusto
Polish addFundsWizardAddress.js
33bef11 
Closes #11378

Auditors:

Test Plan:
1. Open about:preferences#payments
2. Click add funds
3. Click BAT
4. Make sure the layout is not broken
@luixxiul luixxiul added this to the 0.22.x (Nightly Channel) milestone Nov 21, 2017
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 14, 2018 •
edited by LaurenWags
Loading

Verified on Windows x64 using

  • 0.23.8 06c657b
  • muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.11 6565c06
  • Muon 7.1.0
  • libchromiumcontent 67.0.3396.87

This was referenced Jun 19, 2018
Closed
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/about-pages QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @srirambv @LaurenWags @btlechowski