Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

pinning tabs when a window has been closed results in error #11833

Closed
petemill opened this issue Nov 8, 2017 · 0 comments
Closed

pinning tabs when a window has been closed results in error #11833

petemill opened this issue Nov 8, 2017 · 0 comments

Comments

@petemill
Copy link
Member

petemill commented Nov 8, 2017

Description

pinning tabs when a window has been closed results in error 'Object has been destroyed'

Steps to Reproduce

  1. Start browser (clean profile)
  2. Open some tabs
  3. Open a new window (ctrlorcmd-n)
  4. Close newly opened window (ctwlorcmd-w)
  5. Pin one of the tabs in the original window

Actual result:
Error:

An uncaught exception occurred in the main process Uncaught Exception:
Error: Object has been destroyed
    at updatePinnedTabs (/Users/petemill/Development/Brave/browser-laptop/app/browser/windows.js:76:11)
    at Immediate.setImmediate (/Users/petemill/Development/Brave/browser-laptop/app/browser/windows.js:244:11)
    at runCallback (timers.js:672:20)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate [as _immediateCallback] (timers.js:617:5)

Expected result:
No error

Reproduces how often:

Brave Version

about:brave info:
master

Reproducible on current live release:
0.19 pinned tab code is different - does not have many of the fixes in 0.20 / master

@petemill petemill added this to the Triage Backlog milestone Nov 8, 2017
@petemill petemill self-assigned this Nov 8, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Nov 8, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Nov 8, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Nov 9, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Nov 9, 2017
bsclifton pushed a commit to petemill/browser-laptop that referenced this issue Nov 13, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, 0.20.x (Beta Channel) Nov 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.