Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Automatically append user-data-dir-name on Linux for different channels #11900

Closed
darkdh opened this issue Nov 10, 2017 · 0 comments · Fixed by #11901
Closed

Automatically append user-data-dir-name on Linux for different channels #11900

darkdh opened this issue Nov 10, 2017 · 0 comments · Fixed by #11901
Assignees
@darkdh
Labels
OS/unix-like/linux QA/checked-Linux QA/test-plan-specified release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@darkdh
Copy link
Member

darkdh commented Nov 10, 2017 •
edited by bsclifton
Loading

Test plan

See #11901

Original issue description

We've already done this on Windows for squirrel first time launch, launching the executable directly not by shortcut and launched Brave through terminal without specifying the switch

Linux users love launching things from terminal so it is better to add the switch for non Release channels

cc @bsclifton
@darkdh darkdh added this to the 0.20.x (Beta Channel) milestone Nov 10, 2017
@darkdh darkdh self-assigned this Nov 10, 2017
darkdh added a commit that referenced this issue Nov 10, 2017
@darkdh
Automatica add user-data-dir-name to non Release channels
c0b2109 
fix #11900

Auditors: @bsclifton

Test Plan:
a. CHANNEL=beta npm start shouldn't relaunch

b. CHANNEL=beta npm build-package
b-1. ./brave-beta-linux-x64/brave-beta should relaunch and use
brave-beta as user dir
b-2 CHANNEL=beta npm build-installer
b-3 Install Brave by dist/x64/brave-beta_0.*.*_amd64.deb/x86_64.rpm
b-4 launch brave-beta from terminal should relaunch and use brave-beta
as user dir
@darkdh darkdh mentioned this issue Nov 10, 2017
Merged
8 tasks
@srirambv srirambv mentioned this issue Dec 20, 2017
Closed
27 tasks
This was referenced Dec 27, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
OS/unix-like/linux QA/checked-Linux QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Automatically add user-data-dir-name to non Release channels brave/browser-laptop
3 participants
@bsclifton @darkdh @srirambv