Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Changing pinned values is not working correctly #12450

Closed
NejcZdovc opened this issue Dec 31, 2017 · 2 comments
Closed

Changing pinned values is not working correctly #12450

NejcZdovc opened this issue Dec 31, 2017 · 2 comments
Assignees
@NejcZdovc
Labels
0.19.x issue first seen in 0.19.x feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

Description

This was first noticed on reddit https://www.reddit.com/r/BATProject/comments/7ls63a/brave_setting_payment_s_in_brave_is_extremely/. Actually what is happening is that when you set a pinned value and then just clicking to another pin inputs values changes randomly.

Steps to Reproduce

  1. Add 3 publishers to the clean ledger
  2. Pin this 3 publishers
  3. Set % to one input
  4. Click to another two inputs and value will change

Actual result:

Values changes when you click on other inputs

Expected result:
Values shouldn't change for other inputs

Reproduces how often:

100%

Brave Version

about:brave info:

Brave: 0.19.123
rev: f45cb3a
Muon: 4.5.31
libchromiumcontent: 63.0.3239.108
V8: 6.3.292.48
Node.js: 7.9.0
Update Channel: Release
OS Platform: macOS
OS Release: 17.2.0
OS Architecture: x64

Reproducible on current live release:

yes

Additional Information

dec-31-2017 19-04-17
@NejcZdovc NejcZdovc added 0.19.x issue first seen in 0.19.x feature/rewards labels Dec 31, 2017
@NejcZdovc NejcZdovc added this to the 0.20.x (Beta Channel) milestone Dec 31, 2017
@NejcZdovc NejcZdovc self-assigned this Dec 31, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 31, 2017
@NejcZdovc
Fixes changing pinned values
71f8950 
Resolves brave#12450

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Dec 31, 2017
Merged
10 tasks
@srirambv
Copy link
Collaborator

srirambv commented Jan 2, 2018

This is dupe to #11238 and #12002 ?

@NejcZdovc
Copy link
Contributor Author

no it's not a dupe, because this issue/PR fixes only one regression and don't fix this two existing issues

bsclifton added a commit that referenced this issue Jan 2, 2018
@bsclifton
Merge pull request #12451 from NejcZdovc/hotfix/#12450-pin
ed4d33c 
Fixes changing pinned values
bsclifton added a commit that referenced this issue Jan 2, 2018
@bsclifton
Merge pull request #12451 from NejcZdovc/hotfix/#12450-pin
4666dfa 
Fixes changing pinned values
bsclifton added a commit that referenced this issue Jan 2, 2018
@bsclifton
Merge pull request #12451 from NejcZdovc/hotfix/#12450-pin
8e3df1b 
Fixes changing pinned values
This was referenced Jan 9, 2018
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.19.x issue first seen in 0.19.x feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
4 participants
@bsclifton @NejcZdovc @srirambv @LaurenWags