Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

IndexedDB not working in web worker #12463

Closed
armhub opened this issue Jan 2, 2018 · 19 comments
Closed

IndexedDB not working in web worker #12463

armhub opened this issue Jan 2, 2018 · 19 comments
Assignees
@bsclifton
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.23.x Release 2 ...

Comments

@armhub
Copy link

armhub commented Jan 2, 2018 •
edited by bsclifton
Loading

Test plan

See brave/muon#629

Description

IndexedDB can not be used in web workers. The call indexedDB.open() never returns. In the gui thread it works fine.
You can test it here: http://raananw.github.io/WebWorkers-IndexedDB/

Steps to Reproduce

Call indexedDB.open("a") in a worker context.

Actual result:
The call never returns.

Expected result:
The call returns.

Reproduces how often:
Always

Brave Version

about:brave info:
Brave | 0.19.123
rev | f45cb3a
Muon | 4.5.31
libchromiumcontent | 63.0.3239.108
V8 | 6.3.292.48
Node.js | 7.9.0
Update Channel | Release
OS Platform | Linux
OS Release | 4.10.0-42-generic
OS Architecture | x64

Reproducible on current live release:
Yes

Additional Information
@armhub armhub mentioned this issue Jan 2, 2018
Closed
@luixxiul luixxiul added the bug label Jan 17, 2018
@pete-willard
Copy link

pete-willard commented Feb 15, 2018 •
edited
Loading

any chance this issue gets some attention soon?

@pete-willard pete-willard mentioned this issue Feb 21, 2018
Closed
@ryanpcmcquen
Copy link

This one really hurts ...

@youphyun
Copy link

Can this be fixed? Brave is a secure browser oriented around privacy but it prevents the Tutanota mail app at mail.tutanota.com from being loaded.

@eljuno
Copy link
Contributor

eljuno commented May 24, 2018

+1 from community https://community.brave.com/t/tutanota-mail-not-logging-in/22642?u=eljuno

@eljuno
Copy link
Contributor

eljuno commented Jun 15, 2018

cc @bsclifton

@lnyim
Copy link

lnyim commented Jun 23, 2018

+1 Tutanota is my main email service provider

@janos-szenfner
Copy link

When will you fix the issue?

@pete-willard
Copy link

I am no longer using Brave because of this 🤷‍♂️

@janos-szenfner
Copy link

I can understand it. I am thinking the same. Please fix this issue.

@janos-szenfner
Copy link

I also moved to Vivaldi browser because of this. Will somebody do something?

@NejcZdovc NejcZdovc mentioned this issue Jul 2, 2018
Closed
@bsclifton bsclifton self-assigned this Jul 2, 2018
@bsclifton
Copy link
Member

Got a fix for this! Hang tight

bsclifton added a commit to brave/muon that referenced this issue Jul 5, 2018
@bsclifton
Add support for missing events:
988abb8 
- AllowDatabase
- AllowDOMStorage
- RequestFileSystemAccess
- AllowIndexedDB

Fixes brave/browser-laptop#12463
Fixes brave/browser-laptop#14475

Possibly addresses brave/browser-laptop#10685

Auditors: @darkdh, @bridiver
bsclifton added a commit to brave/muon that referenced this issue Jul 5, 2018
@bsclifton
Add support for missing events:
e9c11a6 
- AllowDatabase
- AllowDOMStorage
- RequestFileSystemAccess
- AllowIndexedDB

Fixes brave/browser-laptop#12463
Fixes brave/browser-laptop#14475

Possibly addresses brave/browser-laptop#10685

Auditors: @darkdh, @bridiver
@bsclifton bsclifton mentioned this issue Jul 5, 2018
Merged
bsclifton added a commit to brave/muon that referenced this issue Jul 5, 2018
@bsclifton
Add support for missing events:
7d366eb 
- AllowDatabase
- AllowDOMStorage
- RequestFileSystemAccess
- AllowIndexedDB

Fixes brave/browser-laptop#12463
Fixes brave/browser-laptop#14475

Possibly addresses brave/browser-laptop#10685

Auditors: @darkdh, @bridiver
bsclifton added a commit to brave/muon that referenced this issue Jul 6, 2018
@bsclifton
Add support for missing events:
de28298 
- AllowDatabase
- AllowDOMStorage
- AllowIndexedDB

*Includes fixes from review feedback*

Fixes brave/browser-laptop#12463
Fixes brave/browser-laptop#14475

Possibly addresses brave/browser-laptop#10685
This was referenced Jul 6, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jul 6, 2018

Verified on Windows 10 x64 using

  • 0.23.31 - 3148ace
  • Muon - 7.1.5
  • libchromiumcontent - 67.0.3396.103

@janos-szenfner
Copy link

Please put it into the beta, dev and nightly channel and put it on to download it. Thanks.

@bsclifton
Copy link
Member

@janos-szenfner you can download a copy here:
https://github.com/brave/browser-laptop/releases/tag/v0.23.31dev

Alternatively, you can launch Brave with the BRAVE_ENABLE_PREVIEW_UPDATES=TRUE environment variable set 😄

@bsclifton
Copy link
Member

Verified on macOS using

  • 0.23.31 - 3148ace
  • Muon - 7.1.5
  • libchromiumcontent 67.0.3396.103

@jasonrsadler
Copy link
Contributor

jasonrsadler commented Jul 6, 2018 •
edited
Loading

Verified on XUbuntu 18.04 using

  • 0.23.31 - 3148ace
  • Muon - 7.1.5
  • libchromiumcontent 67.0.3396.103

@ryanpcmcquen
Copy link

@bsclifton, can we get this on Android too?

@bsclifton
Copy link
Member

@ryanpcmcquen good question - can you open an issue here?
https://github.com/brave/browser-android-tabs/issues

@SergeyZhukovsky, @AlexeyBarabash, or @samartnik should be able to help 😄 👍

@ryanpcmcquen
Copy link

@bsclifton, thanks! Created:
https://github.com/brave/browser-android-tabs/issues/679

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.23.x Release 2 (Release Channel)
Development

No branches or pull requests
12 participants
@ryanpcmcquen @luixxiul @pete-willard @bsclifton @armhub @youphyun @srirambv @jasonrsadler @eljuno @lnyim @janos-szenfner and others