Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

page security state for passive mixed content is incorrect #12742

Closed
diracdeltas opened this issue Jan 19, 2018 · 0 comments
Closed

page security state for passive mixed content is incorrect #12742

diracdeltas opened this issue Jan 19, 2018 · 0 comments
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/include security
Milestone
0.20.x (Release C...

Comments

@diracdeltas
Copy link
Member

STR:

  1. go to mixed.badssl.com
  2. click on urlbar lock icon
  3. it shows this message:
    screen shot 2018-01-19 at 11 03 14 pm

Expected behavior:
It should show this message instead:
screen shot 2018-01-19 at 11 03 29 pm

Not currently reproducible on the released version (0.19.x)

maybe related to https://github.com/brave/muon/pull/377/files#diff-faaead3da8a3aa51eff1331507a67934R331
@diracdeltas diracdeltas self-assigned this Jan 19, 2018
@diracdeltas diracdeltas added this to the 0.20.x (Beta Channel) milestone Jan 19, 2018
@diracdeltas diracdeltas mentioned this issue Jan 20, 2018
Merged
8 tasks
diracdeltas added a commit that referenced this issue Jan 20, 2018
@diracdeltas
Fix displayed mixed content status
6437850 
Fix #12742

Test Plan:
1. test for 'shows partially-secure icon on a site with passive mixed content' should pass
2. follow test plan from #12742
@diracdeltas diracdeltas mentioned this issue Jan 20, 2018
Merged
10 tasks
This was referenced Jan 24, 2018
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/include security
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@diracdeltas @kjozwiak @bsclifton @srirambv @LaurenWags