Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

cannot drag/drop un/lock icon to Bookmarks Toolbar if Toolbar is empty #12911

Closed
LaurenWags opened this issue Jan 29, 2018 · 5 comments
Closed
Labels
0.20.x issue first seen in 0.20.x bug feature/bookmarks fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. priority/P4 Minor loss of function. Workaround usually present. regression wontfix

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 29, 2018

Description

If nothing is on the Bookmarks Toolbar, you cannot drag and drop the lock/unlock icon to add a bookmark to the toolbar.

Steps to Reproduce

  1. Load 0.20.23 with clean profile
  2. Enable 'Bookmark Toolbar' via right-click context menu (or from Bookmarks > Bookmarks Toolbar)
  3. Visit a website and attempt to drag and drop the lock/unlock icon to the toolbar

Actual result:
Site is not added to the toolbar:
bkmk-toolbar-02023

Expected result:
Site should be added to the toolbar:
bkmk-toolbar-019147

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.23
V8 | 6.4.388.40
rev | 5a2da66
Muon | 4.7.8
OS Release | 16.7.0
Update Channel | Release
OS Architecture | x64
OS Platform | macOS
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 64.0.3282.119

Reproducible on current live release:
No

Additional Information

cc @kjozwiak reproduced on Ubuntu and MacOS

@LaurenWags LaurenWags added this to the 0.20.x (Beta Channel) milestone Jan 29, 2018
@bbondy
Copy link
Member

bbondy commented Jan 30, 2018

we can move this to hotfix 1

@bbondy bbondy modified the milestones: 0.20.x (Beta Channel), 0.20.x Hotfix 1 (Referral Promotion) Jan 30, 2018
@srirambv
Copy link
Collaborator

This has been a long standing issue on Windows without items on bookmark toolbar it is impossible to add by dnd on toolbar.
Also mentioned here #11034 (comment)

@NejcZdovc NejcZdovc modified the milestones: 0.20.x Hotfix 1 (Referral Promotion), 0.20.x Hotfix 2 Jan 30, 2018
@cezaraugusto
Copy link
Contributor

reason is that emptu bm toolbar is too narrow for being the drop area. A quick fix would be keeping the toolbar size even if empty not sure why we resized it to what it is now.

if blank space is a problem we could have a placeholder like "add or drag a bookmark from urlbar to populate this area"

@bradleyrichter
Copy link
Contributor

We need a "drop zone" that would toggle the visibility of the BM bar during the drag action.

Possible @cezaraugusto ?

@alexwykoff alexwykoff added the priority/P4 Minor loss of function. Workaround usually present. label Jan 30, 2018
@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), Backlog (Prioritized) Feb 6, 2018
@cezaraugusto cezaraugusto removed their assignment Jul 30, 2018
@rebron rebron added fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix labels Sep 7, 2018
@rebron
Copy link
Collaborator

rebron commented Sep 7, 2018

Closing. Looks like this is fixed in brave-core. https://brave.com/download-dev

@rebron rebron closed this as completed Sep 7, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.20.x issue first seen in 0.20.x bug feature/bookmarks fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. priority/P4 Minor loss of function. Workaround usually present. regression wontfix
Projects
None yet
Development

No branches or pull requests

9 participants