Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Impossible to add bookmark with dnd of padlock if toolbar is disabled #11034

Closed
srirambv opened this issue Sep 20, 2017 · 6 comments
Closed

Impossible to add bookmark with dnd of padlock if toolbar is disabled #11034

srirambv opened this issue Sep 20, 2017 · 6 comments
Labels
bug feature/bookmarks fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. misc/drag-and-drop wontfix

Comments

@srirambv
Copy link
Collaborator

srirambv commented Sep 20, 2017 •
edited by luixxiul
Loading

Description

Impossible to add bookmark with dnd of padlock if toolbar is disabled

Steps to Reproduce

  1. Disable bookmark toolbar
  2. Right click right above the tabs where the bookmark toolbar context menu is shown
  3. Drag and drop the padlock where the bookmark toolbar context menu was shown, doesnt dd the page as bookmark,

Actual result:

addbmk1

Expected result:
Should add bookmark and enable bookmark toolbar
Reproduces how often: [What percentage of the time does it reproduce?]
100%

Brave Version

All

Additional Information

Existing behaviour

#11033
@luixxiul luixxiul added the bug label Sep 20, 2017
@luixxiul luixxiul mentioned this issue Sep 20, 2017
Closed
@luixxiul
Copy link
Contributor

@bbondy does your commit 29e0d34 fix this one too?

@bbondy
Copy link
Member

bbondy commented Sep 29, 2017

I don't think so, the drop handler is on the bookmarks toolbar and if it is disabled then there is no bookmarks toolbar.

@luixxiul
Copy link
Contributor

luixxiul commented Nov 7, 2017

@srirambv do you see the issue on the latest 0.20.x build?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Nov 7, 2017
@srirambv
Copy link
Collaborator Author

srirambv commented Nov 7, 2017

Happens on 0.20.6 as well
11034

@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Nov 7, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@srirambv srirambv mentioned this issue Jan 30, 2018
Closed
@kjozwiak
Copy link
Member

Still reproducible using 0.21.12 246f900 under Win 10 x64.

@rebron rebron removed this from the Triage Backlog milestone Sep 9, 2018
@rebron
Copy link
Collaborator

rebron commented Sep 9, 2018

Closing. Marking wontfix here but fixed in brave-core..

@rebron rebron closed this as completed Sep 9, 2018
@rebron rebron added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug feature/bookmarks fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. misc/drag-and-drop wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bbondy @kjozwiak @luixxiul @bsclifton @rebron @srirambv