Copy and paste function aren't work properly #14197

foxhoundsk · 2018-05-21T17:07:38Z

Description

During browsing, text which is copyable won't being copied using copy button in right click menu, but the ctrl+c is work properly, and same as paste in right click menu (text in copy buffer is for sure due to ctrl+v worked).

Steps to Reproduce

Go to a page which text is copyable.
Try to copy some text with copy button in right click menu and paste it with ctrl+v or paste button in right click menu.
Now, try to copy and paste same text with ctrl+c and ctrl+v, it worked properly.

Actual result:

Expected result:

Copy and paste implemented by browser should work properly.

Reproduces how often:

Brave Version

about:brave info:

Brave: 0.22.714
V8: 6.6.346.26
rev: fa2fbca
Muon: 6.0.9
OS Release: 10.0.17134
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 66.0.3359.139

Reproducible on current live release:

Yes.

Additional Information

Thanks for providing a good browser!!

The text was updated successfully, but these errors were encountered:

bsclifton · 2018-05-22T16:01:30Z

@flawless0714 I'm on Windows 10 using the same version (0.22.714) and I'm having trouble trying to reproduce the problem. Are you still actively experiencing the issue? Does it affect all copy/pastes? or just in a particular tab? Are you switching between tabs before doing the copy/paste?

Any more info would be very much appreciated. Thanks!

bsclifton · 2018-05-22T16:46:11Z

Scenarios I've tried:

Open website, select text on page, right click => copy, paste into Notepad
Open two websites, select text on website 1, switch to website 2, select text, right click => copy, paste into Notepad
Have multiple windows with multiple tabs, select text on window 1, switch to window 2, select text on window 2, right click => copy, paste into Notepad
Open website 1 in one tab and use middle click to open a child page in a new tab, select text on website 2, right click => copy, paste into Notepad

(and probably a few others I've tried too)

Tested on Windows 10 x64 and macOS

btlechowski · 2018-05-22T18:40:00Z

I found reliable STR. Reproduced by me @kjozwiak on Windows 7, Windows 10, Ubuntu 17.10 and Mint 18.3 x64. Not reproducible on Mac.

Go to youtube.com
Right click on a video and open in through 'Open link in new tab'
Hover over the opened tab to show its preview
Activate the opened tab
Try to Cut/Copy/Paste the URL in the URL field through Context Menu

bsclifton · 2018-05-22T19:28:47Z

@btlechowski that only seems to happen with the URL bar (never with the content on the page). Still needs to be fixed... but can you confirm copying content on the page is working as expected?

foxhoundsk · 2018-05-22T19:53:24Z

Ahh..., I should sorry at first, I just found that after restart Brave, the issue has gone..., this make it more complicated to address the issue, the only information I can provide now is that I hibernate my PC every day I went away from it with Brave openned with about 5 or 6 tab.

Edited: will report the status after I hibernate my PC this time.

Keep going!!

btlechowski · 2018-05-22T19:55:31Z

@bsclifton Also reproduced on Textbox. Ubuntu 17.10 x64 v0.22.718.

STR:

Go to about:about
Right click on about:styles and open in through 'Open link in new tab'
Hover over the opened tab to show its preview
Activate the opened tab
Scroll down to 'Plain Textbox'
Type 'asdf' into the Textbox
Try to Cut/Copy/Paste in the Textbox through Context Menu

ghost · 2018-05-23T00:17:10Z

@bsclifton Cool to see you are also in Chandler, been a huge fan of the project and never realized. I just posted this on the community Brave page as well.

The following process has allowed me to replicate the issue several times in a row:

Have several browser tabs open with the browser set up to restore previous tabs.
Close the browser since the issue is triggered sometime after opening with previous tabs.
Reopen the browser seeing all of your old tabs.
Hover over a tab different from the current tab you are viewing, within a couple seconds you will see it is refreshing the tab. At this point the copy + paste is broken.
If that didn’t break it, try hovering a tab to get it to reload, then move your cursor across other tabs to trigger them to also reload.

It seems to be fine for me until I hover a tab (other than the current tab) to get it to reload/refresh.

foxhoundsk · 2018-05-23T06:05:24Z

Hi guys, after my PC wake up from hibernate, it seems everything works fine. And I tried what @jtellingson said, it broke, so I guess this is the bug which triggered the issue I opened!

srirambv · 2018-05-23T11:55:26Z

+1 from @tommycarstensen via brave/brave-browser#219

Often I cannot copy/paste within and from Brave to another application. I'm on version 0.22.714, but I'm unable to provide further information, because copy/paste is broken most of the time. I'm on MacOS 10.11.6.

bsclifton · 2018-05-24T15:33:22Z

+1 from @alexchee via #8000 (comment)

I'm running into this issue but I have more information. I think it's involves multiple tabs with different sessions. It seems to work again for the first window opened and 6 tabs after moving a tab to the first position.

I am able to right click to copy & paste in the first 5 tabs on the first window. But any other tabs (i.e. session 2, session 3, default) or windows, right click to Copy does not copy the text. I am able to Copy with hotkeys cmd+C in any tabs.

Steps to Reproduce:

Open a tab by clicking on +, visit a site (window 1)

Open "New Session Tab 2", visit a site (ex. Fixed copy paste issues - MacOS & Windows 10 #8000)

Open "New Session Tab 3", visit a site

Open "New Session Tab 4", visit a site

Open "New Session Tab 1", visit a site

Open 3 more new tabs with + , visit a site

Drag out a tab into a new Window (window 2)

Select text in new Window tab (window 2)

Right click and select "Copy" in context menu

Paste into URL bar or text editor

Repeat steps 9-10 on different tabs and windows

Actual result:
The pasted text does not match the intended selected copied text.

Expected result:
The pasted text should match the selected and copied text.

I haven't found a way to reproduce it consistently, maybe it's an issue with electron-clipboard. I'll update if I can find a way to consistently reproduce.

Additional Info:
Brave 0.22.714
V8  6.6.346.26
rev fa2fbca
Muon  6.0.9
OS Release  10.0.17134
Update Channel  Release
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync  v1.4.2
libchromiumcontent  66.0.3359.139

srirambv · 2018-05-25T21:31:04Z

+1 from https://community.brave.com/t/i-can-t-copy-and-paste-anything-in-brave/22729/2

MacGurus · 2018-06-04T17:32:26Z

disabling TAB PREVIEWS on HOVER in settings seemed to have fixed the problem for a short while but after more extensive use of the browser right click to copy from both the address bar and text in pages again ceases to function properly but using CNTRL-C does work

this is a fairly serious impediment to using the browser so I hope it can be rectified soon

bsclifton · 2018-06-04T21:38:38Z

~~@btlechowski I can no longer reproduce this on our current release (0.22.727) OR in the beta (0.22.806). Can you test and confirm if it's still an issue? Possibly fixed with #14295~~

bsclifton · 2018-06-05T00:02:32Z

@jonathansampson has confirmed this is still an issue. I had originally tested on macOS; after re-testing on Windows, I can reproduce the issue still

bsclifton · 2018-06-07T20:27:37Z

Reproduced locally with debug build of Muon... digging in more now. Definitely related to the tab preview functionality (maybe wrong frameKey is being set in browser-laptop). When a bad copy happens, the web contents IS getting the copy... but I suspect not the right web contents

bsclifton · 2018-06-07T21:59:21Z

The only difference in the browser-laptop side that I can see is that the preview is attaching to the web view BEFORE the tab is switched to. Versus preview being off, where it attaches as the last step

bsclifton · 2018-06-08T07:43:08Z

Root cause is that wrong web contents is being returned when calling electron.webcontents.getFocusedWebContents. Getting a lot closer to finding the fix

@petemill

focused Fixes brave/browser-laptop#14197 Auditors: @petemill, @bridiver

GeetaSarvadnya · 2018-06-20T15:55:23Z

Verified on Windows 10 x64
• 0.23.11 6565c06
• Muon 7.1.0
• libchromiumcontent 67.0.3396.87

Verified on Ubuntu 17.10 x64

0.23.11 - 6565c06
Muon - 7.1.0
libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

0.23.14 f4da855
Muon 7.1.1
libchromiumcontent 67.0.3396.87

LaurenWags added bug feature/context-menu 0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch labels May 21, 2018

LaurenWags added this to the 0.22.x Release 4 (Beta channel) milestone May 21, 2018

kjozwiak added the release-notes/include label May 21, 2018

bsclifton self-assigned this May 21, 2018

bsclifton added the needs-info Another team member needs information from the PR/issue opener. label May 22, 2018

bsclifton removed their assignment May 22, 2018

bsclifton self-assigned this May 22, 2018

srirambv mentioned this issue May 23, 2018

unable to copy/paste brave/brave-browser#219

Closed

bsclifton modified the milestones: 0.22.x Release 4 (Beta channel), 0.22.x Release 5 May 23, 2018

bsclifton mentioned this issue May 24, 2018

Fixed copy paste issues - MacOS & Windows 10 #8000

Closed

sliday mentioned this issue May 25, 2018

Shortcuts doesn't work when the input alphabet is not Latin. #13559

Closed

bsclifton modified the milestones: 0.22.x Release 5 (Release channel), 0.22.x w/ Chromium 67 (BETA Channel) May 29, 2018

kjozwiak mentioned this issue Jun 1, 2018

cannot copy url from address bar #14301

Closed

bsclifton added the OS/Windows label Jun 4, 2018

bsclifton modified the milestones: 0.22.x w/ Chromium 67 (BETA Channel), 0.23.x (Developer Channel) Jun 6, 2018

bsclifton added a commit to brave/muon that referenced this issue Jun 9, 2018

Check if web contents is attached before allowing it to be considered as

cf76026

focused Fixes brave/browser-laptop#14197 Auditors: @petemill, @bridiver

bsclifton mentioned this issue Jun 9, 2018

Check if web contents is attached before allowing it to be considered as focused brave/muon#606

Merged

bridiver closed this as completed in brave/muon#606 Jun 11, 2018

LaurenWags added QA/test-plan-required and removed OS/Windows labels Jun 11, 2018

This was referenced Jun 19, 2018

Manual test run on OS X for 0.23.x (Beta Channel) #14451

Closed

Manual test run on Windows x64 for 0.23.x (Beta Channel) #14452

Closed

Manual test run on Linux for 0.23.x (Beta Channel) #14453

Closed

GeetaSarvadnya added the QA/checked-Win64 label Jun 20, 2018

btlechowski added the QA/checked-Linux label Jun 20, 2018

This was referenced Jun 21, 2018

Manual test run on OS X for 0.23.x (Beta Channel) #14488

Closed

Manual test run on OS X for 0.23.x (Beta Channel) #14494

Closed

srirambv removed the QA/test-plan-required label Jun 21, 2018

LaurenWags added the QA/checked-macOS label Jun 22, 2018

kjozwiak mentioned this issue Jun 27, 2018

Release notes for 0.23.x (Release Channel) #14583

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copy and paste function aren't work properly #14197

Copy and paste function aren't work properly #14197

foxhoundsk commented May 21, 2018

bsclifton commented May 22, 2018

bsclifton commented May 22, 2018

btlechowski commented May 22, 2018 •

edited

Loading

bsclifton commented May 22, 2018

foxhoundsk commented May 22, 2018 •

edited

Loading

btlechowski commented May 22, 2018

ghost commented May 23, 2018

foxhoundsk commented May 23, 2018 •

edited

Loading

srirambv commented May 23, 2018 •

edited

Loading

bsclifton commented May 24, 2018

srirambv commented May 25, 2018

MacGurus commented Jun 4, 2018 •

edited

Loading

bsclifton commented Jun 4, 2018 •

edited

Loading

bsclifton commented Jun 5, 2018 •

edited

Loading

bsclifton commented Jun 7, 2018 •

edited

Loading

bsclifton commented Jun 7, 2018

bsclifton commented Jun 8, 2018

GeetaSarvadnya commented Jun 20, 2018 •

edited by LaurenWags

Loading

Copy and paste function aren't work properly #14197

Copy and paste function aren't work properly #14197

Comments

foxhoundsk commented May 21, 2018

Description

Steps to Reproduce

Brave Version

Additional Information

bsclifton commented May 22, 2018

bsclifton commented May 22, 2018

btlechowski commented May 22, 2018 • edited Loading

bsclifton commented May 22, 2018

foxhoundsk commented May 22, 2018 • edited Loading

btlechowski commented May 22, 2018

ghost commented May 23, 2018

foxhoundsk commented May 23, 2018 • edited Loading

srirambv commented May 23, 2018 • edited Loading

bsclifton commented May 24, 2018

srirambv commented May 25, 2018

MacGurus commented Jun 4, 2018 • edited Loading

bsclifton commented Jun 4, 2018 • edited Loading

bsclifton commented Jun 5, 2018 • edited Loading

bsclifton commented Jun 7, 2018 • edited Loading

bsclifton commented Jun 7, 2018

bsclifton commented Jun 8, 2018

GeetaSarvadnya commented Jun 20, 2018 • edited by LaurenWags Loading

btlechowski commented May 22, 2018 •

edited

Loading

foxhoundsk commented May 22, 2018 •

edited

Loading

foxhoundsk commented May 23, 2018 •

edited

Loading

srirambv commented May 23, 2018 •

edited

Loading

MacGurus commented Jun 4, 2018 •

edited

Loading

bsclifton commented Jun 4, 2018 •

edited

Loading

bsclifton commented Jun 5, 2018 •

edited

Loading

bsclifton commented Jun 7, 2018 •

edited

Loading

GeetaSarvadnya commented Jun 20, 2018 •

edited by LaurenWags

Loading